New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site_configuration.feature: use POSIX format in timezone #5416

Merged
merged 1 commit into from Sep 28, 2016

Conversation

Projects
None yet
6 participants
@ashmaroli
Member

ashmaroli commented Sep 25, 2016

switch to date/time in POSIX format as value to timezone: key in features/site_configuration.feature since Windows does not seem to understand tz-name specified currently.
Ref: #5414

/cc @jekyll/windows

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 28, 2016

Member

LGTM.

@jekyllbot: merge +dev

Member

parkr commented Sep 28, 2016

LGTM.

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 93c7cdf into jekyll:master Sep 28, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Sep 28, 2016

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 29, 2016

Member

Note to Self: Wait till November (end of DST) to see if this causes any CI failure and then publish documentation.

Member

ashmaroli commented Sep 29, 2016

Note to Self: Wait till November (end of DST) to see if this causes any CI failure and then publish documentation.

@budparr

This comment has been minimized.

Show comment
Hide comment
@budparr

budparr Sep 29, 2016

Contributor

How does this affect DST? Does this change mean I'd have to change the UTC time on all my sites every year? And is it backwards compatible with all the sites I have this set for?

Contributor

budparr commented Sep 29, 2016

How does this affect DST? Does this change mean I'd have to change the UTC time on all my sites every year? And is it backwards compatible with all the sites I have this set for?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 29, 2016

Member

@budparr, the change has been made to just this one cucumber-feature. It will not affect any of the Jekyll sites created till date, and yet to be created.
Besides, you don't have to change anything at all if you don't plan on previewing the site on Windows

How does this affect DST?

I'm yet to confirm.. In theory, it would create problems, but it may not, too..
I was planning to publish related documentation for Windows users who currently face the issue outlined in #5414 but decided to put off till I have solid evidence to back it.

Is this change really necessary?

Yes, if you're in development mode on Windows and for Appveyor to pass that feature.

Member

ashmaroli commented Sep 29, 2016

@budparr, the change has been made to just this one cucumber-feature. It will not affect any of the Jekyll sites created till date, and yet to be created.
Besides, you don't have to change anything at all if you don't plan on previewing the site on Windows

How does this affect DST?

I'm yet to confirm.. In theory, it would create problems, but it may not, too..
I was planning to publish related documentation for Windows users who currently face the issue outlined in #5414 but decided to put off till I have solid evidence to back it.

Is this change really necessary?

Yes, if you're in development mode on Windows and for Appveyor to pass that feature.

@budparr

This comment has been minimized.

Show comment
Hide comment
@budparr

budparr Sep 29, 2016

Contributor

Not sure, I understand. I use the timezone setting in config in all my sites and use critical date-based functionality. Are you saying that one can continue to use America/New_York? as my time-zone setting, and not worry about DST?

Contributor

budparr commented Sep 29, 2016

Not sure, I understand. I use the timezone setting in config in all my sites and use critical date-based functionality. Are you saying that one can continue to use America/New_York? as my time-zone setting, and not worry about DST?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 29, 2016

Member

America/New_York is still valid (and automatically handles DST), except on Windows.
I had issues with it on my Windows system. If you're on Windows too, and had this setting working all this while, I'm willing to consider looking deeper into my system configuration.

Member

ashmaroli commented Sep 29, 2016

America/New_York is still valid (and automatically handles DST), except on Windows.
I had issues with it on my Windows system. If you're on Windows too, and had this setting working all this while, I'm willing to consider looking deeper into my system configuration.

@budparr

This comment has been minimized.

Show comment
Hide comment
@budparr

budparr Sep 29, 2016

Contributor

America/New_York is still valid (and automatically handles DST)

Okay, thanks. That's what I wanted to know.

Contributor

budparr commented Sep 29, 2016

America/New_York is still valid (and automatically handles DST)

Okay, thanks. That's what I wanted to know.

| key | value |
| timezone | America/New_York |
| key | value |
| timezone | UTC+04:00 |

This comment has been minimized.

@parkr

parkr Oct 1, 2016

Member

This should be UTC-4 if it is meant to be New York but you notice how the posts have their own offset so they are unaffected by this:

| entry2    | 2013-04-10 03:14 -0400 | post    | content for entry2. |

becomes:

Post Layout: <p>content for entry2.</p>\n built at 2013-04-10T03:14:00-04:00

That seems to invalidate this test. I believe we'd need to remove the timezone offsets in the date segment of the posts.

@parkr

parkr Oct 1, 2016

Member

This should be UTC-4 if it is meant to be New York but you notice how the posts have their own offset so they are unaffected by this:

| entry2    | 2013-04-10 03:14 -0400 | post    | content for entry2. |

becomes:

Post Layout: <p>content for entry2.</p>\n built at 2013-04-10T03:14:00-04:00

That seems to invalidate this test. I believe we'd need to remove the timezone offsets in the date segment of the posts.

This comment has been minimized.

@ashmaroli

ashmaroli Oct 1, 2016

Member

A thread on StackExchange for reference..

@ashmaroli

This comment has been minimized.

@ashmaroli

ashmaroli Oct 1, 2016

Member

I believe we'd need to remove the timezone offsets in the date segment of the posts.

local tests show, there's no difference to whether the offset in post.date is present or not..

@ashmaroli

ashmaroli Oct 1, 2016

Member

I believe we'd need to remove the timezone offsets in the date segment of the posts.

local tests show, there's no difference to whether the offset in post.date is present or not..

@ashmaroli ashmaroli changed the title from site_configuration.feature: use UTC format in timezone to site_configuration.feature: use POSIX format in timezone Oct 1, 2016

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Oct 1, 2016

Member

@parkr may I suggest an edit to History.markdown along the lines of the new title..?

Member

ashmaroli commented Oct 1, 2016

@parkr may I suggest an edit to History.markdown along the lines of the new title..?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment