New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site template: Move contents of the index.html page to the 'home' layout #5420

Merged
merged 3 commits into from Sep 27, 2016

Conversation

Projects
None yet
5 participants
@DirtyF
Member

DirtyF commented Sep 27, 2016

Reflects changes in jekyll/minima#48

/cc @jekyll/core

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 27, 2016

Member

@DirtyF, few questions:

  • what do you say to adding a comment telling users they need not edit the empty index.html they now see..?
  • is using index.md instead of index.html a bad-idea?
    If done so, we could add a title: Home; permalink: / and minima will automatically add this page to the top-nav
Member

ashmaroli commented Sep 27, 2016

@DirtyF, few questions:

  • what do you say to adding a comment telling users they need not edit the empty index.html they now see..?
  • is using index.md instead of index.html a bad-idea?
    If done so, we could add a title: Home; permalink: / and minima will automatically add this page to the top-nav

DirtyF added some commits Sep 27, 2016

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Sep 27, 2016

Member

@ashmaroli good catch, applied your recommendations, except for title and permalink as It seems perfectly fine to me as it is.

Member

DirtyF commented Sep 27, 2016

@ashmaroli good catch, applied your recommendations, except for title and permalink as It seems perfectly fine to me as it is.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 27, 2016

Member

except for title and permalink as it seems perfectly fine to me as it is.

Thanks Frank, but according to this, unless those parameters are set, the top-nav wont have the link defined.
I wont press on including them though, as this line already links to the blog's root.

Member

ashmaroli commented Sep 27, 2016

except for title and permalink as it seems perfectly fine to me as it is.

Thanks Frank, but according to this, unless those parameters are set, the top-nav wont have the link defined.
I wont press on including them though, as this line already links to the blog's root.

@parkr

Not sure if the .md extension will have negative side effects, but we'll test it out.

@parkr

parkr approved these changes Sep 27, 2016

@parkr parkr changed the title from Move contents of the index.html page to the 'home' layout to Site template: Move contents of the index.html page to the 'home' layout Sep 27, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 27, 2016

Member

@jekyllbot: merge +minor

Member

parkr commented Sep 27, 2016

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit a69919e into jekyll:master Sep 27, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@parkr parkr added this to the 3.3 milestone Sep 27, 2016

jekyllbot added a commit that referenced this pull request Sep 27, 2016

@DirtyF DirtyF deleted the DirtyF:site_template branch Sep 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment