New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jekyll 3.3 release post #5442

Merged
merged 4 commits into from Oct 6, 2016

Conversation

Projects
None yet
7 participants
@parkr
Member

parkr commented Oct 4, 2016

@jekyll/core @jekyll/documentation @benbalter – for review.

  • Write post
  • Generate list of contributors (once all PR's are in)
  • Regenerate history.md and fix link so it points to v3.3 release notes specifically

/cc #5400

@parkr parkr added the documentation label Oct 4, 2016

@parkr parkr assigned benbalter and unassigned parkr Oct 4, 2016

Show outdated Hide outdated site/_posts/2016-10-03-jekyll-3-3-0-released.markdown
front matter, and it will simply be copied over like a static asset. Neat,
huh?
See our [documentation on the subject](/docs/assets#assets-directory) for

This comment has been minimized.

@DirtyF

DirtyF Oct 4, 2016

Member

@parkr Didn't you mean to point to /docs/themes/#assets instead?

@DirtyF

DirtyF Oct 4, 2016

Member

@parkr Didn't you mean to point to /docs/themes/#assets instead?

This comment has been minimized.

@parkr

parkr Oct 4, 2016

Member

Yes! Good catch. 😄

@parkr

parkr Oct 4, 2016

Member

Yes! Good catch. 😄

As always, thanks to our many contributors who contributed countless hours
of their free time to making this release happen:
!! TODO: Add list of contributors for this release!

This comment has been minimized.

@DirtyF

DirtyF Oct 4, 2016

Member

Here is the list returned by git shortlog da0b45..HEAD -s:

Parker Moore, Ashwin Maroli, Frank Taillandier, Jussi Kinnula, Jordon Bedwell, David Zhang, Florian Thomas, XhmikosR, Anthony Gaudino, Pat Hawks, mertkahyaoglu, Jeff Kolesky, Jonathan Thornton, Nadjib Amar, Nicolas Hoizey, Manmeet Gill, Zlatan Vasović, Anatoliy Yastreb, vohedge, Antonio, Ben Balter, Charles Horn, Chris Finazzo, Eduardo Bouças, Edward Thomson, Gerardo, Júnior Messias, Kyle O'Brien, Mark H. Wilkinson, Mertcan Gökgöz, Michal Švácha, Mike Kasberg, Nicolas Porcel, Patrick Marsceill, Stephen Checkoway, Stuart Kent, shingo-nakanishi

@DirtyF

DirtyF Oct 4, 2016

Member

Here is the list returned by git shortlog da0b45..HEAD -s:

Parker Moore, Ashwin Maroli, Frank Taillandier, Jussi Kinnula, Jordon Bedwell, David Zhang, Florian Thomas, XhmikosR, Anthony Gaudino, Pat Hawks, mertkahyaoglu, Jeff Kolesky, Jonathan Thornton, Nadjib Amar, Nicolas Hoizey, Manmeet Gill, Zlatan Vasović, Anatoliy Yastreb, vohedge, Antonio, Ben Balter, Charles Horn, Chris Finazzo, Eduardo Bouças, Edward Thomson, Gerardo, Júnior Messias, Kyle O'Brien, Mark H. Wilkinson, Mertcan Gökgöz, Michal Švácha, Mike Kasberg, Nicolas Porcel, Patrick Marsceill, Stephen Checkoway, Stuart Kent, shingo-nakanishi

This comment has been minimized.

@parkr

parkr Oct 4, 2016

Member

Thanks! Gonna generate this once all the PR's are in.

@parkr

parkr Oct 4, 2016

Member

Thanks! Gonna generate this once all the PR's are in.

@parkr parkr added this to the 3.3 milestone Oct 4, 2016

@benbalter

Nice. A solid release. Lots of quality-of-life features for users and theme developers alike.

Show outdated Hide outdated site/_posts/2016-10-03-jekyll-3-3-0-released.markdown
categories: [release]
---
We have tons of new features for you in our latest release of Jekyll. Three

This comment has been minimized.

@benbalter

benbalter Oct 4, 2016

Contributor

Personal nit, I prefer to write from the user's perspective "here's what you can use" more than our perspective "we have lots of features for you".

@benbalter

benbalter Oct 4, 2016

Contributor

Personal nit, I prefer to write from the user's perspective "here's what you can use" more than our perspective "we have lots of features for you".

This comment has been minimized.

@adamhollett

adamhollett Oct 4, 2016

Contributor

+1 for this, and good observation, Ben.

@adamhollett

adamhollett Oct 4, 2016

Contributor

+1 for this, and good observation, Ben.

This comment has been minimized.

@parkr

parkr Oct 5, 2016

Member

I can't get anything to sound good. This is the best I got:

There are tons of great new quality-of-life features you can use in 3.3. Three key things you might want to give a whirl:

@parkr

parkr Oct 5, 2016

Member

I can't get anything to sound good. This is the best I got:

There are tons of great new quality-of-life features you can use in 3.3. Three key things you might want to give a whirl:

This comment has been minimized.

@adamhollett

adamhollett Oct 5, 2016

Contributor

That sounds fine to me! Though I might replace 'give a whirl' with just 'try'. But that's the tech writer in me talking. :)

@adamhollett

adamhollett Oct 5, 2016

Contributor

That sounds fine to me! Though I might replace 'give a whirl' with just 'try'. But that's the tech writer in me talking. :)

Show outdated Hide outdated site/_posts/2016-10-03-jekyll-3-3-0-released.markdown
to use a theme that was packaged as a gem. Due to security necessities and
ease-of-use concerns, this initial ship only included support for includes,
layouts, and sass partials. A theme couldn't write any CSS, JavaScript, or
content to your site.

This comment has been minimized.

@benbalter

benbalter Oct 4, 2016

Contributor
  1. Was it really security? I thought it was just us being iterative and getting something out the door to nail the basics before adding additional features.
  2. I don't know what we need to spend the entire first paragraph of the post talking about what users used to not be able to do. Let's get to what they can do faster. e.g., "Back in 3.2 we shipped themes... we're adding to that today with..."
  3. I like the human tone, but does the reader really care if we're stoked?
@benbalter

benbalter Oct 4, 2016

Contributor
  1. Was it really security? I thought it was just us being iterative and getting something out the door to nail the basics before adding additional features.
  2. I don't know what we need to spend the entire first paragraph of the post talking about what users used to not be able to do. Let's get to what they can do faster. e.g., "Back in 3.2 we shipped themes... we're adding to that today with..."
  3. I like the human tone, but does the reader really care if we're stoked?
Show outdated Hide outdated site/_posts/2016-10-03-jekyll-3-3-0-released.markdown
In an effort to make theme management a bit easier, any files you put into
`/assets` in your theme will be read in as though they were part of the
user's site. This means you can ship SCSS and CoffeeScript, images and
webfonts, JSON and other data. Same rules apply here as in a Jekyll site:

This comment has been minimized.

@benbalter

benbalter Oct 4, 2016

Contributor

JSON and other data

I don't know that we want to plant that seed. Themes should be about packaging presentation not content (that's what the site is for).

@benbalter

benbalter Oct 4, 2016

Contributor

JSON and other data

I don't know that we want to plant that seed. Themes should be about packaging presentation not content (that's what the site is for).

Show outdated Hide outdated site/_posts/2016-10-03-jekyll-3-3-0-released.markdown
user's site. This means you can ship SCSS and CoffeeScript, images and
webfonts, JSON and other data. Same rules apply here as in a Jekyll site:
if it has YAML front matter, it will be converted and renderd. No YAML
front matter, and it will simply be copied over like a static asset. Neat,

This comment has been minimized.

@benbalter

benbalter Oct 4, 2016

Contributor

Do you want to mention that this is only true if it doesn't already exist in the site?

@benbalter

benbalter Oct 4, 2016

Contributor

Do you want to mention that this is only true if it doesn't already exist in the site?

Want a clean way to prepend the `baseurl` or `url` in your config? These
new filters have you covered. When working locally, if you set your
`baseurl` to match your deployment environment, say `baseurl: "/myproject"`,

This comment has been minimized.

@benbalter

benbalter Oct 4, 2016

Contributor

Do we want to use the opportunity to explain how baseurl should be used? I can see lots of users using this filter and setting their baseurl to / as a result.

@benbalter

benbalter Oct 4, 2016

Contributor

Do we want to use the opportunity to explain how baseurl should be used? I can see lots of users using this filter and setting their baseurl to / as a result.

Show outdated Hide outdated site/_posts/2016-10-03-jekyll-3-3-0-released.markdown
`url: http://localhost:4000`. When you are developing locally, `site.url`
will yield `http://localhost:4000`.
Note that this only applies when `JEKYLL_ENV` is equal to `development`. If

This comment has been minimized.

@benbalter

benbalter Oct 4, 2016

Contributor

What if JEKYLL_ENV isn't set?

@benbalter

benbalter Oct 4, 2016

Contributor

What if JEKYLL_ENV isn't set?

This comment has been minimized.

@DirtyF

DirtyF Oct 4, 2016

Member

Isn't JEKYLL_ENV set to developmentby default?

@DirtyF

DirtyF Oct 4, 2016

Member

Isn't JEKYLL_ENV set to developmentby default?

This comment has been minimized.

@Crunch09
@Crunch09
Show outdated Hide outdated site/_posts/2016-10-03-jekyll-3-3-0-released.markdown
`/assets` in your theme will be read in as though they were part of the
user's site. This means you can ship SCSS and CoffeeScript, images and
webfonts, JSON and other data. Same rules apply here as in a Jekyll site:
if it has YAML front matter, it will be converted and renderd. No YAML

This comment has been minimized.

@Crunch09

Crunch09 Oct 5, 2016

Member

I'm not a native english speaker, but isn't it rendered ?

@Crunch09

Crunch09 Oct 5, 2016

Member

I'm not a native english speaker, but isn't it rendered ?

This comment has been minimized.

@ashmaroli

ashmaroli Oct 5, 2016

Member

yes @Crunch09, it should be rendered Nice catch!

@ashmaroli

ashmaroli Oct 5, 2016

Member

yes @Crunch09, it should be rendered Nice catch!

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Oct 5, 2016

Member

@parkr, can I ask you to add a section about bundle install being initiated automatically after new-site generation.? I think its best to give our users a heads-up and have them be aware of the --skip-bundle switch right away..

Member

ashmaroli commented Oct 5, 2016

@parkr, can I ask you to add a section about bundle install being initiated automatically after new-site generation.? I think its best to give our users a heads-up and have them be aware of the --skip-bundle switch right away..

@parkr parkr referenced this pull request Oct 5, 2016

Closed

Jekyll 3.3 Release Gameplan #5400

9 of 9 tasks complete

@benbalter benbalter assigned parkr and unassigned DirtyF and benbalter Oct 5, 2016

@pathawks pathawks referenced this pull request Oct 5, 2016

Closed

Jekyll Archives broken by Jekyll 3.3 #5417

6 of 9 tasks complete
@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Oct 6, 2016

Member

Jekyll 3.3.0.pre.rc1 does not seem to be backwards compatible to me..

  • Minima _requires_ to be updated to 2.0. (#5453)
  • JekyllArchives _requires_ to be updated. (#5417)
  • JekyllAdmin _requires_ to be updated. (#5451)
  • and many other (unknown-to-me) plugins that use Jekyll 3.2 API

Correct me, if I'm wrong, but I think Jekyll 3.3 should actually be Jekyll 4 echoing @pathawks' comment.

Member

ashmaroli commented Oct 6, 2016

Jekyll 3.3.0.pre.rc1 does not seem to be backwards compatible to me..

  • Minima _requires_ to be updated to 2.0. (#5453)
  • JekyllArchives _requires_ to be updated. (#5417)
  • JekyllAdmin _requires_ to be updated. (#5451)
  • and many other (unknown-to-me) plugins that use Jekyll 3.2 API

Correct me, if I'm wrong, but I think Jekyll 3.3 should actually be Jekyll 4 echoing @pathawks' comment.

@Crunch09

This comment has been minimized.

Show comment
Hide comment
@Crunch09

Crunch09 Oct 6, 2016

Member

JekyllAdmin requires to be updated. (#5451)

FWIW the change which caused this error is not part of the public API so i didn't think it would cause any issues.

That said, another option would be to revert this: #5451 (comment)

Member

Crunch09 commented Oct 6, 2016

JekyllAdmin requires to be updated. (#5451)

FWIW the change which caused this error is not part of the public API so i didn't think it would cause any issues.

That said, another option would be to revert this: #5451 (comment)

Show outdated Hide outdated site/_posts/2016-10-03-jekyll-3-3-0-released.markdown
Note that if a user has a file of the same path, the theme content will not
be included in the site, i.e. a user's `/assets/main.scss` will be written
instead of a theme's `/assets/main.scss`. It's

This comment has been minimized.

@ashmaroli

ashmaroli Oct 6, 2016

Member

what do think about L28 saying be included in the site, i.e. a user's /assets/main.scss will be read and processed instead?
L29 seems incomplete.. ends with a It's

@ashmaroli

ashmaroli Oct 6, 2016

Member

what do think about L28 saying be included in the site, i.e. a user's /assets/main.scss will be read and processed instead?
L29 seems incomplete.. ends with a It's

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 6, 2016

Member

@jekyllbot: merge +site

Member

parkr commented Oct 6, 2016

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit b4393e2 into master Oct 6, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@jekyllbot jekyllbot deleted the 3-3-release-post branch Oct 6, 2016

jekyllbot added a commit that referenced this pull request Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment