New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Commands::Serve#server_address signature change. #5456

Merged
merged 2 commits into from Oct 6, 2016

Conversation

Projects
None yet
6 participants
@parkr
Member

parkr commented Oct 6, 2016

This reverts a tiny part of #5431, which introduced a backwards-incompatible change that JekyllAdmin was relying on. It's never fun to break things and jekyll-admin must have a stunning reputation for not breaking. 馃槃

This is also necessary because launch_browser also used server_address and wasn't updated. So we have to handle that anyway.

/cc @jekyll/stability

@parkr parkr added the fix label Oct 6, 2016

@parkr parkr added this to the 3.3 milestone Oct 6, 2016

@jekyllbot jekyllbot assigned oe and parkr Oct 6, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 6, 2016

Member

/cc @benbalter as well.

Member

parkr commented Oct 6, 2016

/cc @benbalter as well.

@envygeeks

Okay.

@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter Oct 6, 2016

Contributor

馃憤 this doesn't fix the breaking change for Jekyll Admin, but we were monkey patching the process method, so I'm fine with pushing the complexity into JekyllAdmin here, doing what's best for Jekyll, and making the necessary change upstream.

Contributor

benbalter commented Oct 6, 2016

馃憤 this doesn't fix the breaking change for Jekyll Admin, but we were monkey patching the process method, so I'm fine with pushing the complexity into JekyllAdmin here, doing what's best for Jekyll, and making the necessary change upstream.

@ashmaroli

Fixes #5451, so 馃憤

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 6, 2016

Member

The breaking change was the creation of the start_webrick method, which I think we should keep. Monkey-patching is not really something we should feel we need to support, anyway, and Ben is fine with pushing it upstream. I'd love to get a jekyll-admin fix out before 3.3.

Member

parkr commented Oct 6, 2016

The breaking change was the creation of the start_webrick method, which I think we should keep. Monkey-patching is not really something we should feel we need to support, anyway, and Ben is fine with pushing it upstream. I'd love to get a jekyll-admin fix out before 3.3.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Oct 6, 2016

Member

FWIW, v3.3.0 doesnt break jekyll-admin with this change incorporated..

Member

ashmaroli commented Oct 6, 2016

FWIW, v3.3.0 doesnt break jekyll-admin with this change incorporated..

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 6, 2016

Member

@jekyllbot: merge +bug

Member

parkr commented Oct 6, 2016

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 21cd382 into master Oct 6, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@jekyllbot jekyllbot added bug fix labels Oct 6, 2016

@jekyllbot jekyllbot deleted the revert-server-address-sig-change branch Oct 6, 2016

jekyllbot added a commit that referenced this pull request Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment