This reverts a tiny part of #5431, which introduced a backwards-incompatible change that JekyllAdmin was relying on. It's never fun to break things and jekyll-admin must have a stunning reputation for not breaking. 😄
This is also necessary because launch_browser also used server_address and wasn't updated. So we have to handle that anyway.
Revert Commands::Serve#server_address signature change.
/cc @benbalter as well.
👍 this doesn't fix the breaking change for Jekyll Admin, but we were monkey patching the process method, so I'm fine with pushing the complexity into JekyllAdmin here, doing what's best for Jekyll, and making the necessary change upstream.
Fixes #5451, so 👍
Oh fine, rubocop.
The breaking change was the creation of the start_webrick method, which I think we should keep. Monkey-patching is not really something we should feel we need to support, anyway, and Ben is fine with pushing it upstream. I'd love to get a jekyll-admin fix out before 3.3.
FWIW, v3.3.0 doesnt break jekyll-admin with this change incorporated..
@jekyllbot: merge +bug
Update history to reflect merge of #5456 [ci skip]