New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only warn about auto-regeneration bug on Bash On Windows. #5464

Merged
merged 2 commits into from Nov 10, 2016

Conversation

Projects
None yet
6 participants
@envygeeks
Contributor

envygeeks commented Oct 7, 2016

No description provided.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 7, 2016

Member

/cc @jekyll/windows – is there someone who would be willing to try this out?

Member

parkr commented Oct 7, 2016

/cc @jekyll/windows – is there someone who would be willing to try this out?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Oct 7, 2016

Member

Do you mean test it out..? I'll volunteer..

Member

ashmaroli commented Oct 7, 2016

Do you mean test it out..? I'll volunteer..

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 7, 2016

Member

Do you mean test it out..? I'll volunteer..

Yep. Thanks!

Member

parkr commented Oct 7, 2016

Do you mean test it out..? I'll volunteer..

Yep. Thanks!

@parkr parkr added fix windows labels Oct 7, 2016

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Oct 7, 2016

Member

Test passed.. was able to view regenerated site successfully..

Member

ashmaroli commented Oct 7, 2016

Test passed.. was able to view regenerated site successfully..

Show outdated Hide outdated lib/jekyll/commands/build.rb
"https://github.com/Microsoft/BashOnWindows/issues/216"
if Utils::Platforms.bash_on_windows?
Jekyll.logger.warn "", "--watch arg is unsupported in Bash on Windows. "
Jekyll.logger.warn "", "Please see: https://github.com/Microsoft/BashOnWindows/issues/216"

This comment has been minimized.

@parkr

parkr Oct 7, 2016

Member

Looks like this line is too long per the fmt build failure.

@parkr

parkr Oct 7, 2016

Member

Looks like this line is too long per the fmt build failure.

This comment has been minimized.

@ashmaroli

ashmaroli Oct 7, 2016

Member

*fmt 👆

@ashmaroli

ashmaroli Oct 7, 2016

Member

*fmt 👆

This comment has been minimized.

@parkr

parkr Oct 7, 2016

Member

Yep. I review on my phone (with autocorrect) a lot.

@parkr

parkr Oct 7, 2016

Member

Yep. I review on my phone (with autocorrect) a lot.

Show outdated Hide outdated lib/jekyll/commands/build.rb
if Utils::Platforms.bash_on_windows?
Jekyll.logger.warn "", "--watch arg is unsupported in Bash on Windows. "
Jekyll.logger.warn "", "Please see: https://github.com/Microsoft/BashOnWindows/issues/216"
Jekyll.logger.warn "", "If iNotify is fixed, please file a ticket."

This comment has been minimized.

@Daniel15

Daniel15 Oct 9, 2016

inotify (all lowercase). It's not an Apple product 😛

@Daniel15

Daniel15 Oct 9, 2016

inotify (all lowercase). It's not an Apple product 😛

This comment has been minimized.

@envygeeks

envygeeks Oct 9, 2016

Contributor

I'll care about that when people start saying GNU/Linux instead of Linux. ;)

@envygeeks

envygeeks Oct 9, 2016

Contributor

I'll care about that when people start saying GNU/Linux instead of Linux. ;)

@Daniel15

This comment has been minimized.

Show comment
Hide comment
@Daniel15

Daniel15 Oct 9, 2016

Thanks! This fixes watching for me on Windows.

Daniel15 commented Oct 9, 2016

Thanks! This fixes watching for me on Windows.

@parkr

parkr approved these changes Oct 24, 2016

Thank you! We can ship this as v3.3.1.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 24, 2016

Member

Fixes #5462.

Member

parkr commented Oct 24, 2016

Fixes #5462.

@DirtyF DirtyF added this to the 3.3.1 milestone Oct 24, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 25, 2016

Contributor

I'll fix the fmt error in the morning.

Contributor

envygeeks commented Oct 25, 2016

I'll fix the fmt error in the morning.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 25, 2016

Contributor

oh wait no, I was supposed to remove this entirely, BashOnWindows will support iNotify in the next release.

Contributor

envygeeks commented Oct 25, 2016

oh wait no, I was supposed to remove this entirely, BashOnWindows will support iNotify in the next release.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 25, 2016

Contributor

I'll adjust the pull to reflect that in the morning.

Contributor

envygeeks commented Oct 25, 2016

I'll adjust the pull to reflect that in the morning.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 25, 2016

Member

oh wait no, I was supposed to remove this entirely, BashOnWindows will support iNotify in the next release.

Oh nice!

Member

parkr commented Oct 25, 2016

oh wait no, I was supposed to remove this entirely, BashOnWindows will support iNotify in the next release.

Oh nice!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 9, 2016

Member

Hey @envygeeks, what else needs to be done here?

Member

parkr commented Nov 9, 2016

Hey @envygeeks, what else needs to be done here?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Nov 9, 2016

Contributor

I think I need to fix the format error, I'll get it done in the morning, I've ben so busy I forgot about this.

Contributor

envygeeks commented Nov 9, 2016

I think I need to fix the format error, I'll get it done in the morning, I've ben so busy I forgot about this.

envygeeks and others added some commits Oct 7, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 10, 2016

Member

Moving from disabling watch altogether to just warning in case they have issues.

Member

parkr commented Nov 10, 2016

Moving from disabling watch altogether to just warning in case they have issues.

@parkr parkr assigned parkr and unassigned envygeeks Nov 10, 2016

@parkr parkr changed the title from Fix #5462: Only shutdown watch in Bash On Windows. to Only warn about auto-regeneration bug on Bash On Windows. Nov 10, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 10, 2016

Member

@jekyllbot: merge +bug

Member

parkr commented Nov 10, 2016

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit f8ec71a into master Nov 10, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels Nov 10, 2016

@jekyllbot jekyllbot deleted the allow-regular-windows-watchers branch Nov 10, 2016

jekyllbot added a commit that referenced this pull request Nov 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment