Only warn about auto-regeneration bug on Bash On Windows. #5464

Merged
merged 2 commits into from Nov 10, 2016

Projects

None yet

6 participants

@envygeeks
Member

No description provided.

@parkr
Member
parkr commented Oct 7, 2016

/cc @jekyll/windows – is there someone who would be willing to try this out?

@envygeeks envygeeks was assigned by jekyllbot Oct 7, 2016
@ashmaroli
Contributor

Do you mean test it out..? I'll volunteer..

@parkr
Member
parkr commented Oct 7, 2016 edited

Do you mean test it out..? I'll volunteer..

Yep. Thanks!

@parkr parkr added fix windows labels Oct 7, 2016
@ashmaroli
Contributor

Test passed.. was able to view regenerated site successfully..

lib/jekyll/commands/build.rb
- "https://github.com/Microsoft/BashOnWindows/issues/216"
+ if Utils::Platforms.bash_on_windows?
+ Jekyll.logger.warn "", "--watch arg is unsupported in Bash on Windows. "
+ Jekyll.logger.warn "", "Please see: https://github.com/Microsoft/BashOnWindows/issues/216"
@parkr
parkr Oct 7, 2016 edited Member

Looks like this line is too long per the fmt build failure.

@ashmaroli
ashmaroli Oct 7, 2016 Contributor

*fmt 👆

@parkr
parkr Oct 7, 2016 Member

Yep. I review on my phone (with autocorrect) a lot.

lib/jekyll/commands/build.rb
+ if Utils::Platforms.bash_on_windows?
+ Jekyll.logger.warn "", "--watch arg is unsupported in Bash on Windows. "
+ Jekyll.logger.warn "", "Please see: https://github.com/Microsoft/BashOnWindows/issues/216"
+ Jekyll.logger.warn "", "If iNotify is fixed, please file a ticket."
@Daniel15
Daniel15 Oct 9, 2016

inotify (all lowercase). It's not an Apple product 😛

@envygeeks
envygeeks Oct 9, 2016 Member

I'll care about that when people start saying GNU/Linux instead of Linux. ;)

@Daniel15
Daniel15 commented Oct 9, 2016

Thanks! This fixes watching for me on Windows.

@parkr
parkr approved these changes Oct 24, 2016 View changes

Thank you! We can ship this as v3.3.1.

@parkr
Member
parkr commented Oct 24, 2016

Fixes #5462.

@DirtyF DirtyF added this to the 3.3.1 milestone Oct 24, 2016
@envygeeks
Member

I'll fix the fmt error in the morning.

@envygeeks
Member

oh wait no, I was supposed to remove this entirely, BashOnWindows will support iNotify in the next release.

@envygeeks
Member

I'll adjust the pull to reflect that in the morning.

@parkr
Member
parkr commented Oct 25, 2016

oh wait no, I was supposed to remove this entirely, BashOnWindows will support iNotify in the next release.

Oh nice!

@parkr
Member
parkr commented Nov 9, 2016

Hey @envygeeks, what else needs to be done here?

@envygeeks
Member

I think I need to fix the format error, I'll get it done in the morning, I've ben so busy I forgot about this.

envygeeks and others added some commits Oct 7, 2016
@envygeeks @parkr envygeeks Fix #5462: Only shutdown watch in Bash On Windows. d71dff7
@parkr parkr Builder.watch: only warn for Bash on Windows, still try watching.
df45f26
@parkr
Member
parkr commented Nov 10, 2016

Moving from disabling watch altogether to just warning in case they have issues.

@parkr parkr assigned parkr and unassigned envygeeks Nov 10, 2016
@parkr parkr changed the title from Fix #5462: Only shutdown watch in Bash On Windows. to Only warn about auto-regeneration bug on Bash On Windows. Nov 10, 2016
@parkr
Member
parkr commented Nov 10, 2016

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit f8ec71a into master Nov 10, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jekyllbot jekyllbot added bug fix labels Nov 10, 2016
@jekyllbot jekyllbot deleted the allow-regular-windows-watchers branch Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment