fix rubocop errors on testing with Rubocop 0.44 #5489

Merged
merged 1 commit into from Oct 18, 2016

Projects

None yet

5 participants

@ashmaroli
Contributor

Rubocop 0.44 introduced a new cop called Metrics/BlockLength that excludes spec files and rakefiles by default. This PR excludes our minitest files as well.
Also excludes 2 other files that got caught in this job.

  • have the new Metrics/BlockLength cop ignore test files and
    jekyll/configuration.rb
  • have AllCops ignore Jekyll Executable which is not going to be
    altered in the near future.
@ashmaroli ashmaroli fix rubocop errors on testing with Rubocop 0.44
  - have the new `Metrics/BlockLength` cop ignore test files and
    `jekyll/configuration.rb`
  - have `AllCops` ignore Jekyll Executable which is not going to be
    altered in the near future.
d1f67bf
@DirtyF DirtyF added the fix label Oct 17, 2016
@parkr
parkr approved these changes Oct 18, 2016 View changes
@parkr parkr added the tests label Oct 18, 2016
@parkr
Member
parkr commented Oct 18, 2016

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 7c901ba into jekyll:master Oct 18, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pathawks
Member

I wonder if @jekyllbot could notice Rubocop errors and maybe try to automatically fix them.

@ashmaroli ashmaroli deleted the ashmaroli:rubocop-fix branch Oct 18, 2016
@ashmaroli
Contributor

I wonder if @jekyllbot could notice Rubocop errors and maybe try to automatically fix them.

or.. we could have a conservative version-lock for Rubocop gem in our Gemfile..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment