fix rubocop errors on testing with Rubocop 0.44 #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- have the new `Metrics/BlockLength` cop ignore test files and
`jekyll/configuration.rb`
- have `AllCops` ignore Jekyll Executable which is not going to be
altered in the near future.
ashmaroli
force-pushed
the
rubocop-fix
branch
from
6b48e91
to
d1f67bf
Compare
parkr
approved these changes
Oct 18, 2016
|
@jekyllbot: merge +dev |
|
I wonder if @jekyllbot could notice Rubocop errors and maybe try to automatically fix them. |
or.. we could have a conservative version-lock for Rubocop gem in our Gemfile.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop 0.44 introduced a new cop called
Metrics/BlockLengththat excludes spec files and rakefiles by default. This PR excludes our minitest files as well.Also excludes 2 other files that got caught in this job.
Metrics/BlockLengthcop ignore test files andjekyll/configuration.rbAllCopsignore Jekyll Executable which is not going to bealtered in the near future.