include a hashbang for all benchmark scripts & make them executable #5505

merged 1 commit into from Oct 24, 2016


None yet

4 participants

pnn commented Oct 22, 2016

i have no idea what the circumstances of the benchmark scripts are (i cant even find their usage anywhere in the repo) but it's weird how some files have a hashbang, and even then, none of them are executable. this PR adds hashbangs (#!/usr/bin/env ruby, to be precise) to all benchmark files and makes them executable.

@pnn pnn include a hashbang for all benchmark scripts
this also makes every benchmark script executable
@DirtyF DirtyF added the tests label Oct 22, 2016
DirtyF commented Oct 22, 2016
@parkr parkr was assigned by DirtyF Oct 22, 2016
parkr approved these changes Oct 24, 2016 View changes

Sure! I usually do BENCHMARK=true bundle exec ruby benchmark/<file> to run them so I never bothered adding them or making them executable.

parkr commented Oct 24, 2016

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit bc5e59c into jekyll:master Oct 24, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
continuous-integration/travis-ci/pr The Travis CI build passed
pnn commented Oct 25, 2016

it's just for consistency anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment