New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permalinks to docs in '/maintaining/' #5532

Merged
merged 1 commit into from Nov 3, 2016

Conversation

Projects
None yet
4 participants
@ashmaroli
Member

ashmaroli commented Nov 3, 2016

@DirtyF

DirtyF approved these changes Nov 3, 2016

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 3, 2016

Member

@jekyllbot: merge+site

Member

DirtyF commented Nov 3, 2016

@jekyllbot: merge+site

@DirtyF DirtyF closed this Nov 3, 2016

@jekyllbot jekyllbot merged commit b9a17e0 into jekyll:master Nov 3, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Nov 3, 2016

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 3, 2016

Member

@ashmaroli thanks!

Member

DirtyF commented Nov 3, 2016

@ashmaroli thanks!

@ashmaroli ashmaroli deleted the ashmaroli:perma-docs branch Nov 3, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 3, 2016

Member

Wait I removed these on purpose. Why did you add them back in? Was something wrong?

Member

parkr commented Nov 3, 2016

Wait I removed these on purpose. Why did you add them back in? Was something wrong?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 3, 2016

Member

Wait I removed these on purpose. Was something wrong?

@parkr Issue #5531 happened.. though merging this did not solve it..

Member

ashmaroli commented Nov 3, 2016

Wait I removed these on purpose. Was something wrong?

@parkr Issue #5531 happened.. though merging this did not solve it..

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 3, 2016

Member

@parkr yes, htmlproofer _site/ --disable-external returned 13 errors:

- _site/docs/maintaining/becoming-a-maintainer.html
  *  internally linking to reviewing-a-pull-request.md, which does not exist (line 311)
     <a href="reviewing-a-pull-request.md">follow our guide for reviewing pull requests</a>
  *  internally linking to triaging-an-issue.md, which does not exist (line 299)
     <a href="triaging-an-issue.md">More tips on Triaging an Issue in our maintainer guide</a>
- _site/docs/maintaining/index.html
  *  internally linking to affinity-team-captain/, which does not exist (line 294)
     <a href="affinity-team-captain/">Affinity teams &amp; their captains</a>
  *  internally linking to avoiding-burnout/, which does not exist (line 298)
     <a href="avoiding-burnout/">Avoiding burnout</a>
  *  internally linking to becoming-a-maintainer/, which does not exist (line 305)
     <a href="becoming-a-maintainer/">Becoming a maintainer</a>
  *  internally linking to merging-a-pull-request/, which does not exist (line 297)
     <a href="merging-a-pull-request/">Merging a pull request</a>
  *  internally linking to reviewing-a-pull-request/, which does not exist (line 296)
     <a href="reviewing-a-pull-request/">Reviewing a pull request</a>
  *  internally linking to special-labels/, which does not exist (line 299)
     <a href="special-labels/">Special Labels</a>
  *  internally linking to triaging-an-issue/, which does not exist (line 295)
     <a href="triaging-an-issue/">Triaging and issue</a>
- _site/docs/maintaining/merging-a-pull-request.html
  *  internally linking to reviewing-a-pull-request.md, which does not exist (line 295)
     <a href="reviewing-a-pull-request.md">Reviewing a pull request</a>
- _site/docs/maintaining/reviewing-a-pull-request.html
  *  internally linking to ../CONDUCT.markdown, which does not exist (line 293)
     <a href="../CONDUCT.markdown">Code of Conduct</a>
- _site/docs/maintaining/special-labels.html
  *  internally linking to triaging-an-issue.md#staleness-and-automatic-closure, which does not exist (line 305)
     <a href="triaging-an-issue.md#staleness-and-automatic-closure">Triaging an Issue: Staleness and automatic closure</a>
  *  trying to find hash of triaging-an-issue.md#staleness-and-automatic-closure, but /Users/frank/code/jekyll/jekyll/**docs/_site/docs/**maintaining/triaging-an-issue.md does not exist (line 305)
     <a href="triaging-an-issue.md#staleness-and-automatic-closure">Triaging an Issue: Staleness and automatic closure</a>

Specifying permalinks in markdown files does not fix these errors.

Member

DirtyF commented Nov 3, 2016

@parkr yes, htmlproofer _site/ --disable-external returned 13 errors:

- _site/docs/maintaining/becoming-a-maintainer.html
  *  internally linking to reviewing-a-pull-request.md, which does not exist (line 311)
     <a href="reviewing-a-pull-request.md">follow our guide for reviewing pull requests</a>
  *  internally linking to triaging-an-issue.md, which does not exist (line 299)
     <a href="triaging-an-issue.md">More tips on Triaging an Issue in our maintainer guide</a>
- _site/docs/maintaining/index.html
  *  internally linking to affinity-team-captain/, which does not exist (line 294)
     <a href="affinity-team-captain/">Affinity teams &amp; their captains</a>
  *  internally linking to avoiding-burnout/, which does not exist (line 298)
     <a href="avoiding-burnout/">Avoiding burnout</a>
  *  internally linking to becoming-a-maintainer/, which does not exist (line 305)
     <a href="becoming-a-maintainer/">Becoming a maintainer</a>
  *  internally linking to merging-a-pull-request/, which does not exist (line 297)
     <a href="merging-a-pull-request/">Merging a pull request</a>
  *  internally linking to reviewing-a-pull-request/, which does not exist (line 296)
     <a href="reviewing-a-pull-request/">Reviewing a pull request</a>
  *  internally linking to special-labels/, which does not exist (line 299)
     <a href="special-labels/">Special Labels</a>
  *  internally linking to triaging-an-issue/, which does not exist (line 295)
     <a href="triaging-an-issue/">Triaging and issue</a>
- _site/docs/maintaining/merging-a-pull-request.html
  *  internally linking to reviewing-a-pull-request.md, which does not exist (line 295)
     <a href="reviewing-a-pull-request.md">Reviewing a pull request</a>
- _site/docs/maintaining/reviewing-a-pull-request.html
  *  internally linking to ../CONDUCT.markdown, which does not exist (line 293)
     <a href="../CONDUCT.markdown">Code of Conduct</a>
- _site/docs/maintaining/special-labels.html
  *  internally linking to triaging-an-issue.md#staleness-and-automatic-closure, which does not exist (line 305)
     <a href="triaging-an-issue.md#staleness-and-automatic-closure">Triaging an Issue: Staleness and automatic closure</a>
  *  trying to find hash of triaging-an-issue.md#staleness-and-automatic-closure, but /Users/frank/code/jekyll/jekyll/**docs/_site/docs/**maintaining/triaging-an-issue.md does not exist (line 305)
     <a href="triaging-an-issue.md#staleness-and-automatic-closure">Triaging an Issue: Staleness and automatic closure</a>

Specifying permalinks in markdown files does not fix these errors.

parkr added a commit that referenced this pull request Nov 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment