Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation on jekyllrb.com #5540

Merged
merged 1 commit into from Nov 3, 2016
Merged

Update documentation on jekyllrb.com #5540

merged 1 commit into from Nov 3, 2016

Conversation

matthewdu
Copy link
Contributor

The previous doc about categories and tags does not seem to be true.

For

--- # Front Matter
...
categories: piano, music
...

---

and

--- # Front Matter
...
categories: "piano, music"
...

---

the parsed output for categories is

"categories"=>["piano,", "music"] # there's an extra comma

The same applies with tags

You can verify this by logging data at https://github.com/jekyll/jekyll/blob/master/lib/jekyll/document.rb#L480

Space-delimited string works though. Better yet, this should probably only say YAML list.

@ashmaroli
Copy link
Member

/cc @jekyll/documentation

Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DirtyF
Copy link
Member

DirtyF commented Nov 3, 2016

@jekyllbot: merge +site

@DirtyF DirtyF closed this Nov 3, 2016
@jekyllbot jekyllbot merged commit c0341ad into jekyll:master Nov 3, 2016
jekyllbot added a commit that referenced this pull request Nov 3, 2016
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants