New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation on jekyllrb.com #5540

Merged
merged 1 commit into from Nov 3, 2016

Conversation

Projects
None yet
5 participants
@matthewdu
Contributor

matthewdu commented Nov 3, 2016

The previous doc about categories and tags does not seem to be true.

For

--- # Front Matter
...
categories: piano, music
...

---

and

--- # Front Matter
...
categories: "piano, music"
...

---

the parsed output for categories is

"categories"=>["piano,", "music"] # there's an extra comma

The same applies with tags

You can verify this by logging data at https://github.com/jekyll/jekyll/blob/master/lib/jekyll/document.rb#L480

Space-delimited string works though. Better yet, this should probably only say YAML list.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

👍

@DirtyF DirtyF added the documentation label Nov 3, 2016

@parkr

parkr approved these changes Nov 3, 2016

@DirtyF

DirtyF approved these changes Nov 3, 2016

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 3, 2016

Member

@jekyllbot: merge +site

Member

DirtyF commented Nov 3, 2016

@jekyllbot: merge +site

@DirtyF DirtyF closed this Nov 3, 2016

@jekyllbot jekyllbot merged commit c0341ad into jekyll:master Nov 3, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Nov 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment