New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test double slash when input = '/' #5542

Merged
merged 3 commits into from Jan 18, 2017

Conversation

Projects
None yet
6 participants
@ashmaroli
Member

ashmaroli commented Nov 3, 2016

test #5541

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli
Member

ashmaroli commented Nov 3, 2016

Show outdated Hide outdated test/test_filters.rb
"url" => "http://example.com",
"baseurl" => nil
})
refute_equal "http://example.com//", filter.absolute_url(page_url)

This comment has been minimized.

@pathawks

pathawks Nov 3, 2016

Member

Same as above

@pathawks

pathawks Nov 3, 2016

Member

Same as above

Show outdated Hide outdated test/test_filters.rb
"url" => "http://example.com",
"baseurl" => "/base"
})
refute_equal "http://example.com/base//", filter.absolute_url(page_url)

This comment has been minimized.

@pathawks

pathawks Nov 3, 2016

Member

Can we assert that it is proper, rather than refuting this particular wrong case?

@pathawks

pathawks Nov 3, 2016

Member

Can we assert that it is proper, rather than refuting this particular wrong case?

This comment has been minimized.

@ashmaroli

ashmaroli Nov 3, 2016

Member

done..

@ashmaroli

ashmaroli Nov 3, 2016

Member

done..

@DirtyF

DirtyF approved these changes Nov 3, 2016

@DirtyF DirtyF added the tests label Nov 3, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 3, 2016

Member

@benbalter, does this look good to you? I don't see a failing test in the history and I don't trust my reading well enough since I was the one who let this slip through in the first place. 😸

Member

parkr commented Nov 3, 2016

@benbalter, does this look good to you? I don't see a failing test in the history and I don't trust my reading well enough since I was the one who let this slip through in the first place. 😸

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Nov 4, 2016

Member

Shouldn't these tests currently be failing? Was something else causing jekyll/jekyll-feed#145?

Member

pathawks commented Nov 4, 2016

Shouldn't these tests currently be failing? Was something else causing jekyll/jekyll-feed#145?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 4, 2016

Member

I was not able to reproduce the error on my Windows machine. Hence wrote these tests to have Travis check it..
an edge case I didn't include in the tests :
test: if the filter produces "//" when the input and baseurl equals "/"

Member

ashmaroli commented Nov 4, 2016

I was not able to reproduce the error on my Windows machine. Hence wrote these tests to have Travis check it..
an edge case I didn't include in the tests :
test: if the filter produces "//" when the input and baseurl equals "/"

@e0i

This comment has been minimized.

Show comment
Hide comment
@e0i

e0i Dec 3, 2016

I have applied the changes manually and checks didn't fail at all. Perhaps it was indeed something else that caused the situation described at #5541 as @pathawks mentioned?

e0i commented Dec 3, 2016

I have applied the changes manually and checks didn't fail at all. Perhaps it was indeed something else that caused the situation described at #5541 as @pathawks mentioned?

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jan 5, 2017

Member

What's up with AppVeyor?

Member

pathawks commented Jan 5, 2017

What's up with AppVeyor?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jan 6, 2017

Member

What's up with AppVeyor?

@pathawks the test log pre-dates fixing AppVeyor on the master. Restarting the build should sort this. To be on the safer side, I'll update the branch to latest master and initiate a new build altogether.

Member

ashmaroli commented Jan 6, 2017

What's up with AppVeyor?

@pathawks the test log pre-dates fixing AppVeyor on the master. Restarting the build should sort this. To be on the safer side, I'll update the branch to latest master and initiate a new build altogether.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 18, 2017

Member

Always good to have extra tests for things like this.

@jekyllbot: merge +bug

Member

parkr commented Jan 18, 2017

Always good to have extra tests for things like this.

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 76e9b8d into jekyll:master Jan 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels Jan 18, 2017

jekyllbot added a commit that referenced this pull request Jan 18, 2017

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jan 18, 2017

Member

@parkr I think it would be better that @jekyllbot adds a single label bug-fix instead of the current two.. mainly because tagging a PR with bug doesn't seem that right.

Member

ashmaroli commented Jan 18, 2017

@parkr I think it would be better that @jekyllbot adds a single label bug-fix instead of the current two.. mainly because tagging a PR with bug doesn't seem that right.

@ashmaroli ashmaroli referenced this pull request Apr 29, 2017

Closed

Handle '//' (double slash) caused by baseurl: '/' #6057

4 of 5 tasks complete

@ashmaroli ashmaroli deleted the ashmaroli:url-slash branch Oct 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment