-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad config YAML in collections example #5587
Conversation
If you add the previous version to your config file, you'd get an error on build/serve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
collections
needs to be an array, not a hash.
That's what I thought, but putting this into the config file: collections:
- my_collection:
output: true results in this error in the terminal: Configuration file: /Users/Don/Git Projects/some-site/_config.yml
Source: /Users/Don/Git Projects/some-site
Destination: /Users/Don/Git Projects/some-site/_site
Incremental build: disabled. Enable with --incremental
Generating...
jekyll 3.0.2 | Error: undefined method `gsub' for {"my_collection"=>{"output"=>true}}:Hash Conversely, this collections:
my_collection:
output: true produces no errors and behaves as expected (the collection outputs and I can access it at This also seems to be exactly in line with the current documentation for collections. (Or that same collection documentation from the latest commit on master) Just above that link on those pages is the "Step 1" section, which seems to suggest that if you want to specify metadata for a collection, you must not use an array. From the documentation:
Am I missing something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you! @jekyllbot: merge +site |
If you add the previous version to your config file, you'd get an error on build/serve.