New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example URL inconsistency #5592

Merged
merged 1 commit into from Nov 20, 2016

Conversation

Projects
None yet
4 participants
@brainscript
Contributor

brainscript commented Nov 20, 2016

In case of the GitHub example links URLs like <a href="https://github.com/{{ org.username }}"> with the protocol, the domain and the variable were used, but for the Twitter example link only the {{ author.name }} was set as href. To make it more consistent I added the https://twitter.com/ to the URL.

Fix example URL inconsistency
In case of the GitHub example links like `<a href="https://github.com/{{ org.username }}">` with the full URL plus the variable were used, but for the Twitter example link only the `{{  author.name }}` was set as `href`.
@DirtyF

DirtyF approved these changes Nov 20, 2016

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 20, 2016

Member

@jekyllbot: merge +site

Member

DirtyF commented Nov 20, 2016

@jekyllbot: merge +site

@DirtyF DirtyF closed this Nov 20, 2016

@jekyllbot jekyllbot merged commit 7338191 into jekyll:master Nov 20, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Nov 20, 2016

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF
Member

DirtyF commented Nov 20, 2016

@brainscript thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment