New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrading.md to mention usage of `bundle update` #5604

Merged
merged 2 commits into from Mar 31, 2017

Conversation

Projects
None yet
6 participants
@merrua
Contributor

merrua commented Nov 26, 2016

I've added the case for a simple Jekyll updates so beginners do not need to google for it, or ask.

Update upgrading.md
I've added the case for a simple Jekyll updates so beginners do not need to google for it, or ask.
@pathawks

Aren't we encouraging users to move toward using Bundler?

@DirtyF

As @pathawks said, we recommend the use of Bundler, could you please complete with both instructions?

Show outdated Hide outdated docs/_docs/upgrading.md
@@ -8,3 +8,5 @@ Upgrading from an older version of Jekyll? Upgrading to a new major version of J
- [From 0.x to 1.x and 2.x](/docs/upgrading/0-to-2/)
- [From 2.x to 3.x](/docs/upgrading/2-to-3/)
If you are making a minor update (for example from 3.3.1 to 3.3.2 ) run 'gem update jekyll' when in your site directory.

This comment has been minimized.

@DirtyF

DirtyF Nov 26, 2016

Member

Keeping Jekyll up to date

If you followed our setup recommendations and installed Bundler, run bundle update jekyll or simply bundle update and all your gems will update to the latest versions.
If you don't have Bundler installed, run gem update jekyll

@DirtyF

DirtyF Nov 26, 2016

Member

Keeping Jekyll up to date

If you followed our setup recommendations and installed Bundler, run bundle update jekyll or simply bundle update and all your gems will update to the latest versions.
If you don't have Bundler installed, run gem update jekyll

Show outdated Hide outdated docs/_docs/upgrading.md
@@ -8,3 +8,5 @@ Upgrading from an older version of Jekyll? Upgrading to a new major version of J
- [From 0.x to 1.x and 2.x](/docs/upgrading/0-to-2/)
- [From 2.x to 3.x](/docs/upgrading/2-to-3/)
If you are making a minor update (for example from 3.3.1 to 3.3.2 ) run 'gem update jekyll' when in your site directory.

This comment has been minimized.

@oe

oe Nov 26, 2016

Member

minor nit, but could you take out some of the spaces so that it looks like from 3.3.1 to 3.3.2)?

@oe

oe Nov 26, 2016

Member

minor nit, but could you take out some of the spaces so that it looks like from 3.3.1 to 3.3.2)?

This comment has been minimized.

@oe

oe Nov 26, 2016

Member

whoops, i guess this becomes superfluous if you implement @DirtyF's suggestion

@oe

oe Nov 26, 2016

Member

whoops, i guess this becomes superfluous if you implement @DirtyF's suggestion

Update upgrading.md
Version with bundler update examples as suggested by @DirtyF
@merrua

This comment has been minimized.

Show comment
Hide comment
@merrua

merrua Nov 28, 2016

Contributor

Please take a look at the changed version that gives the bundler command.

Contributor

merrua commented Nov 28, 2016

Please take a look at the changed version that gives the bundler command.

@@ -8,3 +8,6 @@ Upgrading from an older version of Jekyll? Upgrading to a new major version of J
- [From 0.x to 1.x and 2.x](/docs/upgrading/0-to-2/)
- [From 2.x to 3.x](/docs/upgrading/2-to-3/)
If you are making a minor update (for example from 3.3.1 to the latest version at the time 3.3.2) run 'bundle update jekyll' when in your site directory.

This comment has been minimized.

@pathawks

pathawks Nov 28, 2016

Member

I don't think this only applies when making a minor update. Depending on the Gemfile, this could also even update to a new major version of Jekyll.

@pathawks

pathawks Nov 28, 2016

Member

I don't think this only applies when making a minor update. Depending on the Gemfile, this could also even update to a new major version of Jekyll.

This comment has been minimized.

@parkr

parkr Nov 29, 2016

Member

Correct – this applies to any updates. 😄

@parkr

parkr Nov 29, 2016

Member

Correct – this applies to any updates. 😄

This comment has been minimized.

@merrua

merrua Nov 29, 2016

Contributor

Do you have suggestted text, that would not suggest for anyone to try it for something like 3.9.7 to 4.0.0? I wanted the impression a new person should check in those cases without the need for them to understand semantic versioning already ? I don't want to relay on all breaking changes occuring with documentation. As most documentation tends to trail behind.

@merrua

merrua Nov 29, 2016

Contributor

Do you have suggestted text, that would not suggest for anyone to try it for something like 3.9.7 to 4.0.0? I wanted the impression a new person should check in those cases without the need for them to understand semantic versioning already ? I don't want to relay on all breaking changes occuring with documentation. As most documentation tends to trail behind.

@parkr parkr changed the title from Update upgrading.md to Update upgrading.md to mention usage of `bundle update` Mar 31, 2017

@parkr

parkr approved these changes Mar 31, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 31, 2017

Member

Thank you! If someone thinks of a better way, I'm sure they'll come along and submit a PR sooner or later. For now, this is great.

@jekyllbot: merge +docs

Member

parkr commented Mar 31, 2017

Thank you! If someone thinks of a better way, I'm sure they'll come along and submit a PR sooner or later. For now, this is great.

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit da5ee46 into jekyll:master Mar 31, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment