New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct comments in data_reader.rb #5621

Merged
merged 2 commits into from Jan 10, 2017

Conversation

Projects
None yet
6 participants
@rogerogden

rogerogden commented Dec 2, 2016

Updated data_reader.rb comments to more accurately reflect read() and read_data_to() functionality.

Roger Ogden added some commits Dec 2, 2016

Roger Ogden
Fixes #5498
Updated data_reader.rb comments to more accurately reflect read() and read_data_to() functionality.
@ashmaroli

👍 Thanks 😃

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Dec 3, 2016

Member

would suggest an edit to the PR title to be a little descriptive of whats being changed.
Thanks

Member

ashmaroli commented Dec 3, 2016

would suggest an edit to the PR title to be a little descriptive of whats being changed.
Thanks

@pathawks pathawks changed the title from Fixes #5498 to Correct comments in data_reader.rb Dec 3, 2016

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Dec 3, 2016

Member

Fixes #5498

Member

pathawks commented Dec 3, 2016

Fixes #5498

@oe

oe approved these changes Dec 3, 2016

@DirtyF

DirtyF approved these changes Dec 4, 2016

@DirtyF DirtyF closed this Jan 10, 2017

@jekyllbot jekyllbot merged commit bf33dc7 into jekyll:master Jan 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jan 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment