Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Test against Ruby 2.4.0 #5687
Thank you! We should definitely upgrade the pygments.rb dependency as you already did, but it has caused a number of test failures. It would be preferable to see the upgrade & test failures fix in a separate PR so we can keep this focused on the 2.4 upgrade.
It also occurs to me that we should check 2.4 on AppVeyor as well! If that's a possibility, it would be nice to keep Travis & AppVeyor in harmony.
Yeah, agreed. I would like to contain that change in one separate PR so we can always trace back. Feel free to simply fix the tests so the expectations match! The HTML that pygments outputs seems good enough to me.