New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update License #5713

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
7 participants
@DirtyF
Member

DirtyF commented Jan 2, 2017

fix #5710

Add Jekyll contributors, following @benbalter advice.

/cc @pathawks

bump year
- Adding Jekyll contributors, following @benbalter advice.

@DirtyF DirtyF requested review from parkr and benbalter Jan 2, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jan 3, 2017

Member

Thanks @DirtyF!

Member

pathawks commented Jan 3, 2017

Thanks @DirtyF!

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jan 3, 2017

Member

👍
Just a passing thought: Is it practical to use a footnote to link to a page that lists an array of all the contributors till date?

Member

ashmaroli commented Jan 3, 2017

👍
Just a passing thought: Is it practical to use a footnote to link to a page that lists an array of all the contributors till date?

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jan 3, 2017

Member

Is it practical to use a footnote…

It's just a text file – not Markdown, footnotes don't really exist, and we don't want to mess with the format of the file and risk not being detected by licensee

A good thought though 👍

Member

pathawks commented Jan 3, 2017

Is it practical to use a footnote…

It's just a text file – not Markdown, footnotes don't really exist, and we don't want to mess with the format of the file and risk not being detected by licensee

A good thought though 👍

@parkr

parkr approved these changes Jan 3, 2017

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Jan 3, 2017

Member

@jekyllbot: merge +minor

Member

oe commented Jan 3, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 8c01ff5 into master Jan 3, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the bump-license branch Jan 3, 2017

jekyllbot added a commit that referenced this pull request Jan 3, 2017

@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter Jan 3, 2017

Contributor

risk not being detected by licensee

Anything after the date in the copyright line is assumed to be attribution, so there's no reason we couldn't do, e.g., Jekyll Contributors, see https://github.com/jekyll/jekyll/graphs/contributors.

Contributor

benbalter commented Jan 3, 2017

risk not being detected by licensee

Anything after the date in the copyright line is assumed to be attribution, so there's no reason we couldn't do, e.g., Jekyll Contributors, see https://github.com/jekyll/jekyll/graphs/contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment