New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date filters should never raise an exception #5722

Merged
merged 2 commits into from Apr 4, 2017

Conversation

Projects
None yet
4 participants
@jekyllbot
Contributor

jekyllbot commented Jan 5, 2017

PR automatically created for @pathawks.

Failing test: date filter should allow empty input to pass through

pathawks added some commits Jan 5, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
Member

pathawks commented Jan 5, 2017

Fixes #5680
Fixes jekyll/jekyll-sitemap#141

@pathawks pathawks changed the title from Failing test: date filter should allow empty input to pass through to Date filters should never raise an exception Jan 5, 2017

@pathawks pathawks requested a review from parkr Jan 5, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 18, 2017

Member

👍 for being consistent with Liquid.

Member

parkr commented Jan 18, 2017

👍 for being consistent with Liquid.

@parkr

parkr approved these changes Jan 18, 2017

@DirtyF

DirtyF approved these changes Apr 1, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Apr 4, 2017

Member

This looks ready to merge...?

Member

pathawks commented Apr 4, 2017

This looks ready to merge...?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Apr 4, 2017

Member

At your service @pathawks

@jekyllbot: merge +minor

📅

Member

DirtyF commented Apr 4, 2017

At your service @pathawks

@jekyllbot: merge +minor

📅

@jekyllbot jekyllbot merged commit 52ac75b into master Apr 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pull/date-filters-never-raise branch Apr 4, 2017

jekyllbot added a commit that referenced this pull request Apr 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment