New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5730: add gcc and make to the list of requirements #5731

Merged
merged 1 commit into from Jan 17, 2017

Conversation

Projects
None yet
4 participants
@zdroid
Member

zdroid commented Jan 7, 2017

I am just unsure should we provide the link to the GNU make page, as it's dull and its installation instructions are nothing less dull. Also, make can be installed via the build-essentials package.

Show outdated Hide outdated docs/_docs/installation.md
@@ -21,6 +21,7 @@ requirements you’ll need to make sure your system has before you start.
- [NodeJS](https://nodejs.org/), or another JavaScript runtime (Jekyll 2 and
earlier, for CoffeeScript support).
- [Python 2.7](https://www.python.org/downloads/) (for Jekyll 2 and earlier)
- [GCC](https://gcc.gnu.org/install/) and [Make](https://www.gnu.org/software/make/) (in case your system doesn't have them installed)

This comment has been minimized.

@parkr

parkr Jan 7, 2017

Member

Should we include a way to check whether these are installed, e.g. gcc --version and make --version?

@parkr

parkr Jan 7, 2017

Member

Should we include a way to check whether these are installed, e.g. gcc --version and make --version?

This comment has been minimized.

@zdroid

zdroid Jan 7, 2017

Member

@parkr Yes, that seems great. Also, gcc -v and make -v work as well, so we can use the shorter versions.

What syntax do you suggest for adding the information? A note, a code block or just inline code?

@zdroid

zdroid Jan 7, 2017

Member

@parkr Yes, that seems great. Also, gcc -v and make -v work as well, so we can use the shorter versions.

What syntax do you suggest for adding the information? A note, a code block or just inline code?

This comment has been minimized.

@DirtyF

DirtyF Jan 9, 2017

Member

inline code is fine for me.

@DirtyF

DirtyF Jan 9, 2017

Member

inline code is fine for me.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 7, 2017

Member

Fixes #5730.

Member

parkr commented Jan 7, 2017

Fixes #5730.

@zdroid

This comment has been minimized.

Show comment
Hide comment
@zdroid

zdroid Jan 9, 2017

Member

Updated.

Member

zdroid commented Jan 9, 2017

Updated.

@DirtyF

DirtyF approved these changes Jan 9, 2017

Thanks!

@DirtyF DirtyF added the documentation label Jan 9, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 17, 2017

Member

@jekyllbot: merge +site

Member

parkr commented Jan 17, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit bf7e24c into jekyll:master Jan 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jan 17, 2017

@zdroid zdroid deleted the zdroid:gcc-make branch Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment