throw IncludeTagError if error occurs in included file #5767

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
5 participants
@Crunch09
Member

Crunch09 commented Jan 15, 2017

Hi,
at first i thought about using the new Liquid::Error#template_name field but it's only available in Liquid 4 and we already have Jekyll::Tags::IncludeTagError which wasn't used anywhere.

Before:
bildschirmfoto 2017-01-15 um 20 43 15

After:
bildschirmfoto 2017-01-15 um 20 43 43

fixes #5756

/cc @jekyll/build

@parkr

parkr approved these changes Jan 16, 2017

Seems good to me!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 16, 2017

Member

@jekyllbot: merge +minor

Member

parkr commented Jan 16, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 6c4699b into jekyll:master Jan 16, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@parkr parkr added this to the 3.4 milestone Jan 16, 2017

jekyllbot added a commit that referenced this pull request Jan 16, 2017

@Crunch09 Crunch09 referenced this pull request Jul 4, 2017

Closed

Incorrect path in filter errors for included files #6203

6 of 18 tasks complete

@Crunch09 Crunch09 deleted the Crunch09:issue-5756 branch Jul 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment