New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump htmlproofer #5781

Merged
merged 1 commit into from Jan 17, 2017

Conversation

Projects
None yet
4 participants
@DirtyF
Member

DirtyF commented Jan 17, 2017

fix #5777

Note: script/proof could be faster with the use of typhoeus Parallel.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 17, 2017

Member

Note: script/proof could be faster with the use of typhoeus.

How so? html-proofer uses Typhoeus and Hydra to do its work, so I'm wondering how this in fact help us.

Member

parkr commented Jan 17, 2017

Note: script/proof could be faster with the use of typhoeus.

How so? html-proofer uses Typhoeus and Hydra to do its work, so I'm wondering how this in fact help us.

@parkr

parkr approved these changes Jan 17, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jan 17, 2017

Member

@jekyllbot: merge +dev

Member

DirtyF commented Jan 17, 2017

@jekyllbot: merge +dev

@DirtyF DirtyF closed this Jan 17, 2017

@jekyllbot jekyllbot merged commit 8d4cce9 into jekyll:master Jan 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@DirtyF DirtyF deleted the DirtyF:bump-htmlproofer branch Jan 17, 2017

jekyllbot added a commit that referenced this pull request Jan 17, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jan 17, 2017

Member

@parkr you're right sorry. But could Parallel and a bit of caching help avoid recheck every single link every time we run script/proof?

Member

DirtyF commented Jan 17, 2017

@parkr you're right sorry. But could Parallel and a bit of caching help avoid recheck every single link every time we run script/proof?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment