New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layouts default to page or post. #580

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@trans
Contributor

trans commented Jun 17, 2012

This patch defaults layout for pages and posts to page and post respectively. In many cases (I suspect the vast majority) this is a perfect setup. And one need not worry about putting a layout entry in each markup file. This is especially useful to me using a Gollum wiki as the source of my posts b/c I can't add YAML front matter. So having default layouts makes all the difference.

This patch shouldn't have any adverse effect on previous designs since layout was effectively a mandatory field before.

@trans

This comment has been minimized.

Contributor

trans commented Dec 1, 2012

Ping.

@agarie

This comment has been minimized.

agarie commented Dec 18, 2012

Seems useful, but it must be documented somewhere. Just a reminder :)

@trans

This comment has been minimized.

Contributor

trans commented Dec 18, 2012

Good point. I'd be happy to document in the wiki. Just guide me to the proper place to to do so.

@agarie

This comment has been minimized.

agarie commented Dec 20, 2012

Well, you should put this in the documentation of the config parameters. Also, don't forget the tests, your patch probably won't get accepted without them.

@ixti

This comment has been minimized.

Member

ixti commented Dec 20, 2012

Don't forget the tests :D

@kevinSuttle

This comment has been minimized.

kevinSuttle commented Jan 9, 2013

Great idea. +1

@parkr

This comment has been minimized.

Member

parkr commented Jan 10, 2013

@trans Please make these edits on the current master - you can update the docs now that they're in the same branch. And don't forget tests! 😃

@parkr

This comment has been minimized.

Member

parkr commented Jan 10, 2013

Closing this pull request in favour of one submitted on the current master, with docs changes and tests added.

@parkr parkr closed this Jan 10, 2013

@trans

This comment has been minimized.

Contributor

trans commented Jan 11, 2013

Hi, Sorry I am a bit confused. Did someone else submit this? Or are you still asking me to submit a new one?

@parkr

This comment has been minimized.

Member

parkr commented Jan 11, 2013

No, I meant one that has yet to be submitted -- by you :)

@parkr

This comment has been minimized.

Member

parkr commented Jan 12, 2013

Merged in e8c74fe, adding tests & docs now.

parkr added a commit that referenced this pull request Jan 12, 2013

parkr added a commit that referenced this pull request Apr 15, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.