New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convertible#validate_permalink!: ensure the return value of data["permalink"] is a string before asking if it is empty #5878

Merged
merged 1 commit into from Feb 12, 2017

Conversation

Projects
None yet
5 participants
@parkr
Member

parkr commented Feb 11, 2017

Fixes #5804.

Convertible#validate_permalink!: ensure the return value of data["per…
…malink"] is a string before asking if it is empty

@parkr parkr added bug fix labels Feb 11, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr
Member

parkr commented Feb 11, 2017

@parkr parkr assigned pathawks and unassigned parkr Feb 11, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Feb 11, 2017

Member

What happens if it is not a string?

Member

pathawks commented Feb 11, 2017

What happens if it is not a string?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 11, 2017

Member
Member

parkr commented Feb 11, 2017

@oe

oe approved these changes Feb 12, 2017

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Feb 12, 2017

Member

@jekyllbot: merge +bug

Member

oe commented Feb 12, 2017

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit cc7afc1 into master Feb 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels Feb 12, 2017

@jekyllbot jekyllbot deleted the convertible-validate-permalink-emptiness-as-string branch Feb 12, 2017

jekyllbot added a commit that referenced this pull request Feb 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment