Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't raise an error if URL contains a colon #5889
I think it's worth taking a look at where this code came from.
In jekyll/jekyll-paginate#8 Jekyll was choking when trying to create a URL from a template that included invalid keys.
In #2834 (comment) Jekyll dies while trying to write a file that includes a colon in the filename.
#5069 was added to prevent these issues.
If we get rid of this check, we should find some other way to avoid dying catastrophically if a user tries to specify an invalid permalink.
Perhaps the best solution is that, in edge cases where a colon in the permalink is actually desired, the colon be escaped in the permalink #5284 (comment)
I think there are two issues in conflict here:
In scenario 1, the user wants to know that something has gone wrong so that the problem can be fixed.
Failing the build serves scenario 1, but breaks scenario 2.
I believe that scenario 1 is far more common than scenario 2.
Apparently, with the way things are currently, scenario 2 can still be achieved by escaping colons in URLs
If we are going to go out of our way to allow URLs to contain colons, we also need to figure out how to write those files to disk in a way that works across the different operating systems we support.