New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation has been moved out from docs #5927

Merged
merged 1 commit into from Mar 3, 2017

Conversation

Projects
None yet
5 participants
@PedroLamas
Contributor

PedroLamas commented Mar 2, 2017

Change introduced in a05e64c has broken the bottom navigation as the page no longer exists, so I removed it from docs.yml

/cc @jekyll/documentation

Navigation has been moved out from docs
Change introduced in a05e64c has broken the bottom navigation as the page no longer exists, so I removed it from docs.yml
@DirtyF

DirtyF approved these changes Mar 3, 2017

Good catch, thanks for the PR.

@DirtyF DirtyF added the documentation label Mar 3, 2017

@PedroLamas

This comment has been minimized.

Show comment
Hide comment
@PedroLamas

PedroLamas Mar 3, 2017

Contributor

Not a problem, glad to be of help! 😄

Contributor

PedroLamas commented Mar 3, 2017

Not a problem, glad to be of help! 😄

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Mar 3, 2017

Member

@jekyllbot merge +site

Member

mattr- commented Mar 3, 2017

@jekyllbot merge +site

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Mar 3, 2017

Member

(let's hope i did that correctly)

Member

mattr- commented Mar 3, 2017

(let's hope i did that correctly)

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Mar 3, 2017

Member

@mattr- you're missing a :!

Member

oe commented Mar 3, 2017

@mattr- you're missing a :!

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Mar 3, 2017

Member

@jekyllbot: merge +site

Member

mattr- commented Mar 3, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 108b299 into jekyll:master Mar 3, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Mar 3, 2017

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Mar 3, 2017

Member

yes! did it. technology is hard. Thanks @pnn!

Member

mattr- commented Mar 3, 2017

yes! did it. technology is hard. Thanks @pnn!

@PedroLamas PedroLamas deleted the PedroLamas:patch-1 branch Aug 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment