Fix for #176 #593

Closed
wants to merge 2 commits into from
@c-abird

I found it very useful eg. for including subnavigations to be able to pass a variable as argument to the include tag.

@kieransenior

It's useful for many things, if, for example, I had some page variable specified in my pages (say, about.md) like so:

---
myinclude: faces.ext
---

Then I could have

{% include {{myinclude}} %}

in my layout. I've got an example of this on StackOverflow here: http://stackoverflow.com/questions/11300717/dynamic-includes which shows an example where it makes sense. Otherwise, all of my HTML has to be packed into every single view.

@zenorocha

Man, this feature is so damn important.
Please accept this Pull Request so I can use it on Github Pages and not as a custom plugin.

@mbavio

What is the state of this? I need this so much on my github pages, please accept the pull request, I dont want to switch to Octopress!

@parkr
Jekyll member

@mbavio We've got our eye on it! In the next couple weeks, I would guess.

Second change looks great, @c-abird.

@darth10

+1. Waiting to use this on GitHub pages.

@mbavio

@parkr I will owe you a bunch of beers if you can merge this asap. 👍

@mattr-
Jekyll member

There is no guarantee that this will be available right away in GitHub Pages after it's merged. It would require Pages to be upgraded to the version of Jekyll that contains this code.

@mbavio
@parkr
Jekyll member

Yep, @mattr-'s right. The status of this repo has nothing to do with the status of the Jekyll running Github Pages.

Take heed from Patient Bear. He'll wait with you.

patient bear

@agarie

Hey @parkr, do you know if anyone with merge permission reads these PRs? There are a good amount of them (I've seen your messages trying to close the older ones, congratulations for the effort!), so it's a bit strange to see someone saying "in a couple of weeks".

And this is really a nice feature that I'd use. 👍

@parkr
Jekyll member

@agarie Right now, I think just mojombo has merge permissions. I'm talking with him next week about the project, and about whether he might grant me permissions to manage the project. This is the top PR on my list, but we'll see what he says. Thanks for your patience!

@qrush

Closing this for the same reason as #176. I don't want to push Jekyll in this direction.

@qrush qrush closed this Jan 2, 2013
@mbavio

Wow, man, you are really listening to the community!

@mattr-
Jekyll member
@mattgreenfield

As far as I can tell, this is now possible. As of #1495 you can use {% include {{variable}} %}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment