New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appease classifier-reborn #5934

Merged
merged 1 commit into from Mar 7, 2017

Conversation

Projects
None yet
4 participants
@ashmaroli
Member

ashmaroli commented Mar 4, 2017

Addresses #5721
classifier-reborn is not very happy about empty posts in our test suite. This pull adds dummy content to those posts to appease classifier-reborn

/cc @pathawks

@pathawks

Are these posts specifically testing Classifier, or is there some way we can just disable Classifier on everything but whatever we are using it to test?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Mar 4, 2017

Member

Are these posts specifically testing Classifier

No, these posts are not exclusive to testing Classifier. We feed the entire the test posts collection to Classifier to find related test posts, etc etc..
The passing tests confirm that adding a text body to these posts do not interfere with existing tests.

Member

ashmaroli commented Mar 4, 2017

Are these posts specifically testing Classifier

No, these posts are not exclusive to testing Classifier. We feed the entire the test posts collection to Classifier to find related test posts, etc etc..
The passing tests confirm that adding a text body to these posts do not interfere with existing tests.

@parkr

parkr approved these changes Mar 7, 2017

The fact that CI is 💚 tells me we're good to go. Thanks!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 7, 2017

Member

@jekyllbot: merge +dev

Member

parkr commented Mar 7, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 9a740bc into jekyll:master Mar 7, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Mar 7, 2017

@ashmaroli ashmaroli deleted the ashmaroli:appease-classifier branch Oct 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment