New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a template for custom 404 page #5945

Merged
merged 3 commits into from Mar 31, 2017

Conversation

Projects
None yet
7 participants
@ashmaroli
Member

ashmaroli commented Mar 11, 2017

Ref: #5944

Provide a Custom 404 Error Page with jekyll new

Personally, not very happy about including internal CSS. However, this is preferable until Minima decides to ship a layout dedicated to this page.

/cc @pathawks @benbalter

@crispgm

This comment has been minimized.

Show comment
Hide comment
@crispgm

crispgm Mar 11, 2017

Member

It's a good idea. However, it may hardly take effect because we haven't taken control of webserver.

Member

crispgm commented Mar 11, 2017

It's a good idea. However, it may hardly take effect because we haven't taken control of webserver.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Mar 11, 2017

Member

This works on localhost:4000
This should work on GH Pages as per this Help Article

For Apache webservers, users may need to modify their .htaccess but that's a different story.

Member

ashmaroli commented Mar 11, 2017

This works on localhost:4000
This should work on GH Pages as per this Help Article

For Apache webservers, users may need to modify their .htaccess but that's a different story.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Mar 11, 2017

Member

A Custom 404 page on the WEBrick development server

404

Member

ashmaroli commented Mar 11, 2017

A Custom 404 page on the WEBrick development server

404

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Mar 11, 2017

Member

It does work on GH Pages. Sample this

Member

ashmaroli commented Mar 11, 2017

It does work on GH Pages. Sample this

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Mar 11, 2017

Member

Thanks @ashmaroli! Is this documented in our docs? If not, it should be 🍻

Member

pathawks commented Mar 11, 2017

Thanks @ashmaroli! Is this documented in our docs? If not, it should be 🍻

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Mar 11, 2017

Member

Is this documented..

Pardon me, but what exactly were you pointing at?

Member

ashmaroli commented Mar 11, 2017

Is this documented..

Pardon me, but what exactly were you pointing at?

@crispgm

This comment has been minimized.

Show comment
Hide comment
@crispgm

crispgm Mar 11, 2017

Member

@ashmaroli Looks cool! I think we should add a new section on docs to show how to make it work with webservers like nginx.

Member

crispgm commented Mar 11, 2017

@ashmaroli Looks cool! I think we should add a new section on docs to show how to make it work with webservers like nginx.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Mar 11, 2017

Member

I think we should add a new section on docs to show how to make it work with webservers like nginx.

Since this works out-of-the-box on GitHub Pages, I feel a how to.. documentation for nginx and Apache softwares should be on a separate PR to the tutorials collection.

Member

ashmaroli commented Mar 11, 2017

I think we should add a new section on docs to show how to make it work with webservers like nginx.

Since this works out-of-the-box on GitHub Pages, I feel a how to.. documentation for nginx and Apache softwares should be on a separate PR to the tutorials collection.

Show outdated Hide outdated lib/site_template/404.html
position: relative;
left: -100px;
margin: 30px 0;
font-size: 60px;

This comment has been minimized.

@DirtyF

DirtyF Mar 11, 2017

Member

One commonly used blog template should be mobile-first and responsive, even here.

@DirtyF

DirtyF Mar 11, 2017

Member

One commonly used blog template should be mobile-first and responsive, even here.

This comment has been minimized.

@ashmaroli

ashmaroli Mar 11, 2017

Member

Thnx @DirtyF I had totally ignored mobile-friendliness..
Will update.

@ashmaroli

ashmaroli Mar 11, 2017

Member

Thnx @DirtyF I had totally ignored mobile-friendliness..
Will update.

This comment has been minimized.

@ashmaroli

ashmaroli Mar 11, 2017

Member

updated.

404m

@ashmaroli

ashmaroli Mar 11, 2017

Member

updated.

404m

@DirtyF

DirtyF approved these changes Mar 11, 2017

LGTM

Show outdated Hide outdated lib/site_template/404.html
<p><strong>Page not found :(</strong></p>
<p>The requested page could not be found.</p>
<p>Edit the <code>404.html</code> file in your site to show a custom 404 Error Message.</p>

This comment has been minimized.

@benbalter

benbalter Mar 13, 2017

Contributor

Perhaps, "If you're the maintainer of the site, edit the..."

@benbalter

benbalter Mar 13, 2017

Contributor

Perhaps, "If you're the maintainer of the site, edit the..."

This comment has been minimized.

@ashmaroli

ashmaroli Mar 13, 2017

Member

I intended it to be similar to the imperative voice in default {{ site.description }}

@ashmaroli

ashmaroli Mar 13, 2017

Member

I intended it to be similar to the imperative voice in default {{ site.description }}

This comment has been minimized.

@benbalter

benbalter Mar 13, 2017

Contributor

My thinking was that it's almost assumed that you're going to change the default description, but that we shouldn't require a site publisher to customize the 404 (either due to the imperative voice or to remove something that looks potentially embarrassing).

@benbalter

benbalter Mar 13, 2017

Contributor

My thinking was that it's almost assumed that you're going to change the default description, but that we shouldn't require a site publisher to customize the 404 (either due to the imperative voice or to remove something that looks potentially embarrassing).

This comment has been minimized.

@ashmaroli

ashmaroli Mar 13, 2017

Member

Valid point. I'll just remove that line entirely.

@ashmaroli

ashmaroli Mar 13, 2017

Member

Valid point. I'll just remove that line entirely.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 31, 2017

Member

Neat!

@jekyllbot: merge +minor

Member

parkr commented Mar 31, 2017

Neat!

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit e4a0970 into jekyll:master Mar 31, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Mar 31, 2017

@ashmaroli ashmaroli deleted the ashmaroli:template-404 branch Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment