New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tutorial on serving custom Error 404 page #5946

Merged
merged 1 commit into from Mar 24, 2017

Conversation

Projects
None yet
6 participants
@ashmaroli
Member

ashmaroli commented Mar 11, 2017

internal;
}
}
```

This comment has been minimized.

@ashmaroli

ashmaroli Mar 11, 2017

Member

@crispgm Since I don't have ready access to a nginx server, can you please test the above? Thanks

@ashmaroli

ashmaroli Mar 11, 2017

Member

@crispgm Since I don't have ready access to a nginx server, can you please test the above? Thanks

This comment has been minimized.

@crispgm

crispgm Mar 11, 2017

Member

Typically, the configuration is like:

server {
    listen 80; # listen 443 ssl; for https site
    location / {
        root   /path/to/your/site;
        index  index.html;
        error_page 404 /404.html;
    }
}
@crispgm

crispgm Mar 11, 2017

Member

Typically, the configuration is like:

server {
    listen 80; # listen 443 ssl; for https site
    location / {
        root   /path/to/your/site;
        index  index.html;
        error_page 404 /404.html;
    }
}

This comment has been minimized.

@ashmaroli

ashmaroli Mar 11, 2017

Member

okay, are all those declarations within the scope of this tutorial?

@ashmaroli

ashmaroli Mar 11, 2017

Member

okay, are all those declarations within the scope of this tutorial?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Mar 11, 2017

Member

Why do we need this? This information is partly already available: https://help.github.com/articles/creating-a-custom-404-page-for-your-github-pages-site/

What do you think @tomjohnson1492?

Member

DirtyF commented Mar 11, 2017

Why do we need this? This information is partly already available: https://help.github.com/articles/creating-a-custom-404-page-for-your-github-pages-site/

What do you think @tomjohnson1492?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Mar 11, 2017

Member

Why do we need this ?

A request from Pat Hawks
Another request from David Zhang

Member

ashmaroli commented Mar 11, 2017

Why do we need this ?

A request from Pat Hawks
Another request from David Zhang

@tomjoht

This comment has been minimized.

Show comment
Hide comment
@tomjoht

tomjoht Mar 13, 2017

Contributor

I think this tutorial is a worthwhile addition to the Jekyll docs. Although some of the content addresses 404 pages generally and has overlap with some github doc info, the first part of this tutorial is more focused on Jekyll and is something that many people may need. I think this would be a good addition to the tutorials section.

Contributor

tomjoht commented Mar 13, 2017

I think this tutorial is a worthwhile addition to the Jekyll docs. Although some of the content addresses 404 pages generally and has overlap with some github doc info, the first part of this tutorial is more focused on Jekyll and is something that many people may need. I think this would be a good addition to the tutorials section.

@parkr

parkr approved these changes Mar 24, 2017

Seems fine.

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Mar 24, 2017

Member

@jekyllbot: merge +docs

Member

DirtyF commented Mar 24, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 220335c into jekyll:master Mar 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Mar 24, 2017

@ashmaroli ashmaroli deleted the ashmaroli:custom-404-tuts branch Oct 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment