New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to order of interpretation tutorial in Tutorials nav #5952

Merged
merged 2 commits into from Mar 25, 2017

Conversation

Projects
None yet
4 participants
@tomjoht
Contributor

tomjoht commented Mar 13, 2017

Added a link to the Order of interpretation tutorial into the Tutorials nav. This tutorial is published, just not linked.

Add link to order of interpretation tutorial in Tutorials nav
Added a link to the Order of interpretation tutorial into the Tutorials nav. This tutorial is published, just not linked.
@tomjoht

This comment has been minimized.

Show comment
Hide comment
@tomjoht

tomjoht Mar 24, 2017

Contributor

I see that this PR has conflicts. The change is simply adding - orderofinterpretation to the _data/tutorials.yml file. Do you want me to close this PR and open a new one that won't have conflicts? Or do you want to just add this entry yourself? Either way I'm good. Just don't want this tiny PR to be forgotten.

Contributor

tomjoht commented Mar 24, 2017

I see that this PR has conflicts. The change is simply adding - orderofinterpretation to the _data/tutorials.yml file. Do you want me to close this PR and open a new one that won't have conflicts? Or do you want to just add this entry yourself? Either way I'm good. Just don't want this tiny PR to be forgotten.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Mar 24, 2017

Member

I see that this PR has conflicts.

No more conflicts. 🎉

The change is simply adding - orderofinterpretation to the _data/tutorials.yml file.

How did this anti-pattern start? I've seen similar things a few times now.
Pages should be added to navigation in the same PR they are added to the site.

Member

pathawks commented Mar 24, 2017

I see that this PR has conflicts.

No more conflicts. 🎉

The change is simply adding - orderofinterpretation to the _data/tutorials.yml file.

How did this anti-pattern start? I've seen similar things a few times now.
Pages should be added to navigation in the same PR they are added to the site.

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Mar 25, 2017

Member

@jekyllbot: merge +docs

Member

DirtyF commented Mar 25, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 1f00d89 into jekyll:master Mar 25, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Mar 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment