New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create buddyworks #5962

Merged
merged 6 commits into from Mar 22, 2017

Conversation

Projects
None yet
5 participants
@Kivlov84
Contributor

Kivlov84 commented Mar 17, 2017

Added description for configuring a Jekyll build using a free https://buddy.works project.

Create buddyworks
Added description for configuring a Jekyll build using a free https://buddy.works project.
@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Mar 17, 2017

Member

hey, @Kivlov84, thanks for contributing to jekyll! there are a couple of small issues with your pull request that i've noticed:

  • the file extension should be .md, like the other files in this directory
  • i don't think the link formatting in line 15 will work, can you check that again?
Member

oe commented Mar 17, 2017

hey, @Kivlov84, thanks for contributing to jekyll! there are a couple of small issues with your pull request that i've noticed:

  • the file extension should be .md, like the other files in this directory
  • i don't think the link formatting in line 15 will work, can you check that again?
@Kivlov84

This comment has been minimized.

Show comment
Hide comment
@Kivlov84

Kivlov84 Mar 17, 2017

Contributor

hey @pnn, thanks for the review. fixed!

Contributor

Kivlov84 commented Mar 17, 2017

hey @pnn, thanks for the review. fixed!

@DirtyF

DirtyF approved these changes Mar 17, 2017

Kivlov84 added a commit to Kivlov84/jekyll that referenced this pull request Mar 20, 2017

added (buddyworks) to ci list
This can only be approved once jekyll#5962 has been merged.

@DirtyF DirtyF requested a review from oe Mar 20, 2017

@DirtyF DirtyF self-assigned this Mar 20, 2017

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Mar 20, 2017

Member

@Kivlov84 sadly, you can't reassign the links to 0, 1, etc. you should give them unique names such as buddyworks-website instead!

Member

oe commented Mar 20, 2017

@Kivlov84 sadly, you can't reassign the links to 0, 1, etc. you should give them unique names such as buddyworks-website instead!

Update buddyworks.md
added unique links + minor text changes
@Kivlov84

This comment has been minimized.

Show comment
Hide comment
@Kivlov84

Kivlov84 Mar 21, 2017

Contributor

@pnn thanks for pointing that out. I've made all the links unique, everything should be fine now.

Contributor

Kivlov84 commented Mar 21, 2017

@pnn thanks for pointing that out. I've made all the links unique, everything should be fine now.

Show outdated Hide outdated docs/_docs/continuous-integration/buddyworks.md
## 3. Using YAML for configuration
If you prefer configuration as code over GUI, you can generate `buddy.yml` that will create a pipeline with the Jekyll action once you push it to the target branch:

This comment has been minimized.

@oe

oe Mar 21, 2017

Member

the only thing that still bugs me is that this should say generate a buddy.yml. otherwise, all good!

@oe

oe Mar 21, 2017

Member

the only thing that still bugs me is that this should say generate a buddy.yml. otherwise, all good!

This comment has been minimized.

@Kivlov84

Kivlov84 Mar 21, 2017

Contributor

article added

@Kivlov84

Kivlov84 Mar 21, 2017

Contributor

article added

Update buddyworks.md
added article to `buddy.yml`
@pathawks

As noted by @pnn, this would be more readable and maintainable if link references were given names instead of just magic numbers

@oe

oe approved these changes Mar 21, 2017

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Mar 21, 2017

Member

what @pathawks said

Member

oe commented Mar 21, 2017

what @pathawks said

@Kivlov84

This comment has been minimized.

Show comment
Hide comment
@Kivlov84

Kivlov84 Mar 22, 2017

Contributor

@pathawks fixed!

Contributor

Kivlov84 commented Mar 22, 2017

@pathawks fixed!

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Mar 22, 2017

Member

Great one more CI solution, thanks @Kivlov84

@jekyllbot: merge +docs

Member

DirtyF commented Mar 22, 2017

Great one more CI solution, thanks @Kivlov84

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit af0051f into jekyll:master Mar 22, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment