New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer .yaml over .toml #5966

Merged
merged 1 commit into from Mar 20, 2017

Conversation

Projects
None yet
4 participants
@fulldecent
Contributor

fulldecent commented Mar 20, 2017

YAML is mature and already works with Jekyll. This PR recommends YAML as first choice and TOML as second in error messages.

TOML is v0.4.0 and is "changing a lot" according to its author.

And for the love of god, will somebody please read XKCD 927.

@fulldecent fulldecent referenced this pull request Mar 20, 2017

Closed

Prefer .yaml over .toml #1

@oe

oe approved these changes Mar 20, 2017

@DirtyF

DirtyF approved these changes Mar 20, 2017

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Mar 20, 2017

Member

is this a +doc merge?

Member

oe commented Mar 20, 2017

is this a +doc merge?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Mar 20, 2017

Member

@pnn I would label this as +minor+dev

Member

DirtyF commented Mar 20, 2017

@pnn I would label this as +minor+dev

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Mar 20, 2017

Member

@DirtyF necessitating a minor version change for a recommendation change?

Member

oe commented Mar 20, 2017

@DirtyF necessitating a minor version change for a recommendation change?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Mar 20, 2017

Member

@pnn yeah, you're right, minor is not appropriated here and it's not a bug either, so that leaves us with dev I guess.

Member

DirtyF commented Mar 20, 2017

@pnn yeah, you're right, minor is not appropriated here and it's not a bug either, so that leaves us with dev I guess.

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Mar 20, 2017

Member

alright!

Member

oe commented Mar 20, 2017

alright!

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Mar 20, 2017

Member

@jekyllrb: merge +dev

Member

oe commented Mar 20, 2017

@jekyllrb: merge +dev

@jekyllbot jekyllbot merged commit ac1369c into jekyll:master Mar 20, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Mar 20, 2017

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Mar 20, 2017

Member

huh, didn't know @jekyllbot catches my mistakes

Member

oe commented Mar 20, 2017

huh, didn't know @jekyllbot catches my mistakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment