New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters#time helper: Duplicate time before calling #localtime. #5996

Merged
merged 1 commit into from Mar 31, 2017

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Mar 31, 2017

Failure noticed on master: https://travis-ci.org/jekyll/jekyll/jobs/217231764

In Ruby 2.4, Time#localtime modifies the Time instance.
In Ruby 2.3, Time#localtime appears to leave them alone.

Either that, or #to_time used to duplicate and now it doesn't.

Filters#time helper: Duplicate time before calling #localtime.
In Ruby 2.4, Time#localtime modifies the Time instance.
In Ruby 2.3, Time#localtime appears to leave them alone.

@parkr parkr requested a review from pathawks Mar 31, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr
Member

parkr commented Mar 31, 2017

@pathawks

Weird.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 31, 2017

Member

@jekyllbot: merge +fix

Member

parkr commented Mar 31, 2017

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit faf5be4 into master Mar 31, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the duplicate-time-before-call-of-localtime branch Mar 31, 2017

jekyllbot added a commit that referenced this pull request Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment