New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise on "URLs" without apostrophe in docs #6018

Merged
merged 1 commit into from Apr 11, 2017

Conversation

Projects
None yet
4 participants
@zarino
Contributor

zarino commented Apr 11, 2017

I was browsing the Jekyll docs earlier (https://jekyllrb.com/docs/github-pages/) and noticed you were using a mixture of "URLs", "URL’s" (with curly quote) and "URL's" (with straight quote).

screenshot of documentation with urls marked

Apostrophes are unnecessary when pluralising acronyms,[1][2] and avoiding them also makes it easier for readers less familiar with the English language.

So I’ve replaced URL\S?s with URLs across the docs directory, and History.markdown. There was no need to change any of the Ruby code files.

I hope I’ve correctly followed all the guidelines for contributing to Jekyll – but if there’s anything you’d like me to change, let me know. 👍

@DirtyF

DirtyF approved these changes Apr 11, 2017

Thanks @zarino for helping us improving documentation.

History is automatically generated from commits messages but from now on we'll try to stick to this convention.

@oe

oe approved these changes Apr 11, 2017

👍

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Apr 11, 2017

Member

@jekyllbot: merge +docs

Member

oe commented Apr 11, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 034f03e into jekyll:master Apr 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment