New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore final newline in folded YAML string #6054

Merged
merged 3 commits into from Jul 18, 2017

Conversation

Projects
None yet
5 participants
@ashmaroli
Member

ashmaroli commented Apr 28, 2017

before: {{ site.description }} =>

"Write an awesome description for your new site here. You can edit this line in _config.yml. It
will appear in your document head meta (for Google search results) and in your feed.xml site
description./n"

after: {{ site.description }} =>

"Write an awesome description for your new site here. You can edit this line in _config.yml. It
will appear in your document head meta (for Google search results) and in your feed.xml site
description."
ignore final newline in folded YAML string
  before: {{ site.description }} =>
	  "Write an awesome description for your new site here. You can
	  edit this line in _config.yml. It will appear in your document
	  head meta (for Google search results) and in your feed.xml site
	  description./n"

   after: {{ site.description }} =>
	  "Write an awesome description for your new site here. You can
	  edit this line in _config.yml. It will appear in your document
	  head meta (for Google search results) and in your feed.xml site
	  description."
@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli
Member

ashmaroli commented Apr 28, 2017

@parkr

parkr approved these changes May 10, 2017

Nice. Should we also test that the new site's site.config["description"] doesn't have a trailing newline?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli May 10, 2017

Member

Should we also test that the new site's site.config["description"] doesn't have a trailing newline?

I think its implied..

Member

ashmaroli commented May 10, 2017

Should we also test that the new site's site.config["description"] doesn't have a trailing newline?

I think its implied..

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 10, 2017

Member

I think its implied..

That's the point... I don't want it to be implicit, I think if we're making this change we should explicitly test it.

Member

parkr commented May 10, 2017

I think its implied..

That's the point... I don't want it to be implicit, I think if we're making this change we should explicitly test it.

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jun 21, 2017

Member

@ashmaroli do you intend to test for a trailing newline here?

Member

DirtyF commented Jun 21, 2017

@ashmaroli do you intend to test for a trailing newline here?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jun 22, 2017

Member

do you intend to test for a trailing newline here?

Sorry, I forgot all about this. Thanks for reminding.. Will push a commit shortly.

Member

ashmaroli commented Jun 22, 2017

do you intend to test for a trailing newline here?

Sorry, I forgot all about this. Thanks for reminding.. Will push a commit shortly.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jul 18, 2017

Member

Can this be included in v3.6?

Member

ashmaroli commented Jul 18, 2017

Can this be included in v3.6?

@DirtyF

DirtyF approved these changes Jul 18, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jul 18, 2017

Member

@jekyllbot: merge +minor

Member

DirtyF commented Jul 18, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 026f828 into jekyll:master Jul 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jul 18, 2017

@ashmaroli ashmaroli deleted the ashmaroli:yaml-fold-newline branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment