New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document difference between cgi_escape and uri_escape #5970 #6081

Merged
merged 2 commits into from Jun 14, 2017

Conversation

Projects
None yet
4 participants
@crispgm
Member

crispgm commented May 22, 2017

/cc: @pathawks

@DirtyF DirtyF requested a review from pathawks May 23, 2017

@pathawks

This looks good, but we should also mention the different handling of &

@pathawks

This comment has been minimized.

Show comment
Hide comment

@jekyllbot jekyllbot self-assigned this May 23, 2017

@pathawks pathawks assigned pathawks and unassigned jekyllbot May 23, 2017

@crispgm

This comment has been minimized.

Show comment
Hide comment
@crispgm

crispgm May 24, 2017

Member

@pathawk instead of mention different handling of &, I put a link to all reserved characters of URI.

Member

crispgm commented May 24, 2017

@pathawk instead of mention different handling of &, I put a link to all reserved characters of URI.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 14, 2017

Member

@jekyllbot: merge +site

❤️

Member

parkr commented Jun 14, 2017

@jekyllbot: merge +site

❤️

@jekyllbot jekyllbot merged commit 13b9dcd into jekyll:master Jun 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jun 14, 2017

@crispgm crispgm deleted the crispgm:document-for-escapes branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment