New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: rename `gems` to `plugins` #6082

Merged
merged 1 commit into from May 23, 2017

Conversation

Projects
None yet
5 participants
@crispgm
Member

crispgm commented May 22, 2017

When I run the docs locally, Jekyll said:

Deprecation: The 'gems' configuration option has been renamed to 'plugins'. Please update your config file accordingly.
@oe

oe approved these changes May 22, 2017

@DirtyF

DirtyF approved these changes May 23, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF May 23, 2017

Member

Thanks @crispgm

@jekyllbot: merge +site

Member

DirtyF commented May 23, 2017

Thanks @crispgm

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 33ff62e into jekyll:master May 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request May 23, 2017

@crispgm crispgm deleted the crispgm:rename-gems-to-plugins branch May 23, 2017

DirtyF added a commit to DirtyF/jekyll that referenced this pull request Jun 1, 2017

plugins -> gems
Revert #6082 to allow GitHub Pages to build the website correctly

@DirtyF DirtyF referenced this pull request Jun 1, 2017

Closed

plugins -> gems #1

DirtyF added a commit that referenced this pull request Jun 1, 2017

plugins -> gems
Revert #6082 to prevent GitHub Pages automatic build from failing.

@DirtyF DirtyF referenced this pull request Jun 1, 2017

Merged

plugins -> gems #6110

@crispgm

This comment has been minimized.

Show comment
Hide comment
@crispgm

crispgm Jun 1, 2017

Member

GitHub Pages not updated?

Member

crispgm commented Jun 1, 2017

GitHub Pages not updated?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jun 1, 2017

Member

GitHub Pages not updated?

Its a Jekyll 3.5 feature..

Member

ashmaroli commented Jun 1, 2017

GitHub Pages not updated?

Its a Jekyll 3.5 feature..

@crispgm

This comment has been minimized.

Show comment
Hide comment
@crispgm

crispgm Jun 1, 2017

Member

Okay, we should stay on Approved without merge.

Member

crispgm commented Jun 1, 2017

Okay, we should stay on Approved without merge.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jun 1, 2017

Member

Yeah we should have.. but now its probably going to revert merge commit of this PR in PR-6110 and then once GH is at J3.5 we revert PR-6110

Member

ashmaroli commented Jun 1, 2017

Yeah we should have.. but now its probably going to revert merge commit of this PR in PR-6110 and then once GH is at J3.5 we revert PR-6110

@DirtyF DirtyF referenced this pull request Oct 3, 2017

Merged

Docs: updates #6407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment