New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define path with __dir__ #6087

Merged
merged 1 commit into from Jul 25, 2017

Conversation

Projects
None yet
4 participants
@bogdanvlviv
Contributor

bogdanvlviv commented May 24, 2017

".. with __dir__ we can restore order in the Universe."

@parkr

parkr approved these changes Jun 14, 2017

Seems fine. FWIW, Kernel#__dir__ is a method, where __FILE__ is a parse-time constant, so this is a bit slower than using __FILE__ directly, but we're basically always using it with a call to File.dirname so no harm done.

@parkr

Ah. This seems to have broken the tests. We'll need to sort that out first.

@parkr parkr added the internal label Jun 14, 2017

Define path with __dir__
".. with __dir__ we can restore order in the Universe."
@bogdanvlviv

This comment has been minimized.

Show comment
Hide comment
@bogdanvlviv

bogdanvlviv Jun 20, 2017

Contributor

@parkr Thank you for the review! I finally finished this PR.

Contributor

bogdanvlviv commented Jun 20, 2017

@parkr Thank you for the review! I finally finished this PR.

@bogdanvlviv

This comment has been minimized.

Show comment
Hide comment
@bogdanvlviv

bogdanvlviv Jul 25, 2017

Contributor

@parkr please review

Contributor

bogdanvlviv commented Jul 25, 2017

@parkr please review

@parkr

parkr approved these changes Jul 25, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 25, 2017

Member

@jekyllbot: merge +dev

Member

parkr commented Jul 25, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 8f1959b into jekyll:master Jul 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jul 25, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 25, 2017

Member

Thank you, @bogdanvlviv! The consistency is wonderful.

Member

parkr commented Jul 25, 2017

Thank you, @bogdanvlviv! The consistency is wonderful.

@bogdanvlviv

This comment has been minimized.

Show comment
Hide comment
@bogdanvlviv

bogdanvlviv Jul 26, 2017

Contributor

@parkr Thanks!

Contributor

bogdanvlviv commented Jul 26, 2017

@parkr Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment