New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rubocop to 0.49.1 #6093

Merged
merged 3 commits into from Jun 15, 2017

Conversation

Projects
None yet
6 participants
@ayastreb
Contributor

ayastreb commented May 26, 2017

Upgrade Rubocop to 0.49.0

Fix #6089
Fix #6101

@DirtyF

DirtyF approved these changes May 26, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF May 29, 2017

Member

@ayastreb Rubocop 0.49.1 is already out, should we bump?

Member

DirtyF commented May 29, 2017

@ayastreb Rubocop 0.49.1 is already out, should we bump?

@ayastreb

This comment has been minimized.

Show comment
Hide comment
@ayastreb

ayastreb May 29, 2017

Contributor

Bumped 👍

Contributor

ayastreb commented May 29, 2017

Bumped 👍

@@ -136,7 +136,7 @@ def server_address(server, options = {})
private
def format_url(ssl_enabled, address, port, baseurl = nil)
format("%{prefix}://%{address}:%{port}%{baseurl}", {
format("%<prefix>s://%<address>s:%<port>i%<baseurl>s", {

This comment has been minimized.

@pathawks

pathawks May 30, 2017

Member

I’ve never seen this before. Type safety?

@pathawks

pathawks May 30, 2017

Member

I’ve never seen this before. Type safety?

This comment has been minimized.

@ayastreb

ayastreb May 30, 2017

Contributor

It's from this cop - https://github.com/bbatsov/rubocop/blob/master/manual/cops_style.md#styleformatstringtoken
by default it enforces annotated tokens (e.g. %<prefix>s), but can be confgiured to enforce template tokens (e.g. %{prefix}).

Which one do you think we should use?

@ayastreb

ayastreb May 30, 2017

Contributor

It's from this cop - https://github.com/bbatsov/rubocop/blob/master/manual/cops_style.md#styleformatstringtoken
by default it enforces annotated tokens (e.g. %<prefix>s), but can be confgiured to enforce template tokens (e.g. %{prefix}).

Which one do you think we should use?

@ayastreb ayastreb changed the title from Bump Rubocop to 0.49.0 to Bump Rubocop to 0.49.1 May 31, 2017

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli May 31, 2017

Member

Fixes #6089, #6101

@ayastreb adding above line to this PR's body should add a has-pull-request label to those issues automatically ( at least in theory 😃 )

Member

ashmaroli commented May 31, 2017

Fixes #6089, #6101

@ayastreb adding above line to this PR's body should add a has-pull-request label to those issues automatically ( at least in theory 😃 )

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF May 31, 2017

Member

@ashmaroli apparently this does not work for dependency issues, feel free to open an issue on https://github.com/parkr/auto-reply/issues :)

Member

DirtyF commented May 31, 2017

@ashmaroli apparently this does not work for dependency issues, feel free to open an issue on https://github.com/parkr/auto-reply/issues :)

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli May 31, 2017

Member

apparently this does not work for dependency issues

Probably because those lines were not issued by the PR-author..? A bug nevertheless..

Member

ashmaroli commented May 31, 2017

apparently this does not work for dependency issues

Probably because those lines were not issued by the PR-author..? A bug nevertheless..

@ayastreb

This comment has been minimized.

Show comment
Hide comment
@ayastreb

ayastreb Jun 1, 2017

Contributor

Cool, I will try 😎
Fixes #6089, #6101

Contributor

ayastreb commented Jun 1, 2017

Cool, I will try 😎
Fixes #6089, #6101

Show outdated Hide outdated .rubocop.yml
EnforcedHashRocketStyle: table
Layout/AlignParameters:
Enabled: false
EnforcedStyle: with_fixed_indentation

This comment has been minimized.

@parkr

parkr Jun 14, 2017

Member

Is the enforced style useless because we have it disabled?

@parkr

parkr Jun 14, 2017

Member

Is the enforced style useless because we have it disabled?

Show outdated Hide outdated .rubocop.yml
Layout/MultilineOperationIndentation:
EnforcedStyle: indented
Layout/SpaceAroundOperators:
Enabled: false

This comment has been minimized.

@parkr

parkr Jun 14, 2017

Member

Let's enable this.

@parkr

parkr Jun 14, 2017

Member

Let's enable this.

@parkr

parkr approved these changes Jun 14, 2017

😍

@parkr parkr added the internal label Jun 14, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 15, 2017

Member

@jekyllbot: merge +dev

Member

parkr commented Jun 15, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit d3b00cb into jekyll:master Jun 15, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment