New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if hidden collections output a document with a future date #6103

Merged
merged 3 commits into from Jun 14, 2017

Conversation

Projects
None yet
8 participants
@ashmaroli
Member

ashmaroli commented May 31, 2017

Tests #5953

/cc @jekyll/build

Show outdated Hide outdated features/collections.feature
And I have the following documents under the puppies collection:
| title | date | content |
| Rover | 2007-12-31 | content for Rover. |
| Fido | 2020-12-31 | content for Fido. |

This comment has been minimized.

@crispgm

crispgm May 31, 2017

Member

IMO, 2020 is not "future" enough.

@crispgm

crispgm May 31, 2017

Member

IMO, 2020 is not "future" enough.

This comment has been minimized.

@ashmaroli

ashmaroli May 31, 2017

Member

no? In theory, even tomorrow is future.. 😉

@ashmaroli

ashmaroli May 31, 2017

Member

no? In theory, even tomorrow is future.. 😉

This comment has been minimized.

@crispgm

crispgm May 31, 2017

Member

@ashmaroli Right! But 3 years is not far. And this test case will be outdated.

@crispgm

crispgm May 31, 2017

Member

@ashmaroli Right! But 3 years is not far. And this test case will be outdated.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks commented on 64eb1f0 May 31, 2017

😂👍

@DirtyF DirtyF added the tests label May 31, 2017

@parkr

parkr approved these changes Jun 14, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 14, 2017

Member

@jekyllbot: merge +dev

Member

parkr commented Jun 14, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 4299539 into jekyll:master Jun 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jun 14, 2017

@ashmaroli ashmaroli deleted the ashmaroli:future-output-false branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment