New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added windows to docs.yml #6109

Merged
merged 2 commits into from Jun 2, 2017

Conversation

Projects
None yet
5 participants
@HenryKobin
Contributor

HenryKobin commented Jun 1, 2017

Added windows to list of docs in docs.yml after adding updated tutorial to the windows page (#6100)

/cc @jekyll/documentation

Added windows to docs.yml
Added windows to list of docs in docs.yml
@pathawks

This comment has been minimized.

Show comment
Hide comment
Member

pathawks commented Jun 1, 2017

/cc: @jekyll/documentation

@DirtyF

We could keep the Jekyll on Windows title and put it under the installation entry

@HenryKobin

This comment has been minimized.

Show comment
Hide comment
@HenryKobin

HenryKobin Jun 1, 2017

Contributor

@DirtyF I think it would be fine under Installation instead of Windows, because I'm running it with Ruby 2.3 / Jekyll and it's basically running as if I had it natively on Linux. I feel like Bash on windows is reaching the point where we could start allowing Windows users to feel more like they are an officially supported language, so they can at least get involved and start troubleshooting for themselves / contributing more to the jekyll ecosystem.

Let me know what you guys think and I'll change it. Super excited for all the new users! 😀

Contributor

HenryKobin commented Jun 1, 2017

@DirtyF I think it would be fine under Installation instead of Windows, because I'm running it with Ruby 2.3 / Jekyll and it's basically running as if I had it natively on Linux. I feel like Bash on windows is reaching the point where we could start allowing Windows users to feel more like they are an officially supported language, so they can at least get involved and start troubleshooting for themselves / contributing more to the jekyll ecosystem.

Let me know what you guys think and I'll change it. Super excited for all the new users! 😀

Show outdated Hide outdated docs/_data/docs.yml
@@ -6,6 +6,7 @@
- usage
- structure
- configuration
- windows

This comment has been minimized.

@DirtyF

DirtyF Jun 1, 2017

Member

this entry should be next to installation

@DirtyF

DirtyF Jun 1, 2017

Member

this entry should be next to installation

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jun 1, 2017

Member

@HenryKobin I was only talking about the order of the links in the navigation menu. Let's keep it as a separate page for now. If @jekyll/windows says it's bug free, then we'll think about merging all installation instructions on the very same page.

Member

DirtyF commented Jun 1, 2017

@HenryKobin I was only talking about the order of the links in the navigation menu. Let's keep it as a separate page for now. If @jekyll/windows says it's bug free, then we'll think about merging all installation instructions on the very same page.

put windows under installation in docs.yml
moved windows to underneath installation in Getting Started
@HenryKobin

This comment has been minimized.

Show comment
Hide comment
@HenryKobin

HenryKobin Jun 2, 2017

Contributor

@DirtyF corrected.

Contributor

HenryKobin commented Jun 2, 2017

@DirtyF corrected.

@oe

oe approved these changes Jun 2, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jun 2, 2017

Member

@jekyllbot: merge +docs

Member

DirtyF commented Jun 2, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 9c7ac16 into jekyll:master Jun 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jun 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment