New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default `baseurl` to `nil` instead of empty string #6137

Merged
merged 1 commit into from Jun 15, 2017

Conversation

Projects
None yet
5 participants
@parkr
Member

parkr commented Jun 14, 2017

Using an empty string as the default value causes all sorts of problems where you don't know if this is user-specified or not. Using an explicitly "illegal" value, like nil, resolves this issue.

See jekyll/github-metadata#97 for more info.

/cc @jekyll/build @benbalter

Default `baseurl` to `nil` instead of empty string
Using an empty string as the default value causes all sorts of problems
where you don't know if this is user-specified or not. Using an
explicitly "illegal" value, like `nil`, resolves this issue.

See jekyll/github-metadata#97 for more info.

@parkr parkr added the fix label Jun 14, 2017

@parkr parkr requested review from pathawks and benbalter Jun 14, 2017

@parkr parkr referenced this pull request Jun 14, 2017

Closed

Release Jekyll v3.5 #6074

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 15, 2017

Member

@jekyllbot: merge +bug

Member

parkr commented Jun 15, 2017

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 1ae0e83 into master Jun 15, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels Jun 15, 2017

@jekyllbot jekyllbot deleted the baseurl-set-to-nil branch Jun 15, 2017

jekyllbot added a commit that referenced this pull request Jun 15, 2017

parkr added a commit that referenced this pull request Jun 15, 2017

parkr added a commit that referenced this pull request Jun 15, 2017

parkr added a commit that referenced this pull request Jun 18, 2017

parkr added a commit that referenced this pull request Jun 18, 2017

@DirtyF DirtyF added this to the 3.5 milestone Jun 18, 2017

Crunch09 added a commit to Crunch09/jekyll that referenced this pull request Jun 26, 2017

set minimum requirement for jekyll-feed
Since jekyll/jekyll#6137 `baseurl` can be `nil` which throws
an error when passed to `URI.join`. Until jekyll-feed 0.8 the `baseurl`
has been used as argument to `URI.join`.

The usage of `baseurl` has been removed in
jekyll/jekyll-feed@bf728c3

> URI.join('http://example.com', nil)
> ArgumentError: bad argument (expected URI object or URI string)

Crunch09 added a commit to Crunch09/jekyll that referenced this pull request Jun 26, 2017

set minimum requirement for jekyll-feed
Since jekyll/jekyll#6137 `baseurl` can be `nil`. Until jekyll-feed 0.8
the `baseurl` has been used as argument to `URI.join`. When `baseurl`
is `nil` this throws an exeption:

> URI.join('http://example.com', nil)
> ArgumentError: bad argument (expected URI object or URI string)

The usage of `baseurl` within jekyll-feed has been removed in
jekyll/jekyll-feed@bf728c3

Merovius added a commit to Merovius/website that referenced this pull request Sep 20, 2018

Add baseurl to _config.yml
Jekyll now defaults baseurl to nil instead of empty string: jekyll/jekyll#6137
This causes builds to break, because the sitemap plugin uses it to build URLs: https://github.com/nnev/website/blob/cd9cc1d6982bc18acda5f72a11957b9ffe0172b0/www/_plugins/sitemap_generator.rb#L184

A better long-term fix is to get a new version of the sitemap plugin, but for now, let's just overwrite the default explicitly to fix the build.

@Merovius Merovius referenced this pull request Sep 20, 2018

Merged

Add baseurl to _config.yml #88

stapelberg added a commit to nnev/website that referenced this pull request Sep 20, 2018

Add baseurl to _config.yml (#88)
Jekyll now defaults baseurl to nil instead of empty string: jekyll/jekyll#6137
This causes builds to break, because the sitemap plugin uses it to build URLs: https://github.com/nnev/website/blob/cd9cc1d6982bc18acda5f72a11957b9ffe0172b0/www/_plugins/sitemap_generator.rb#L184

A better long-term fix is to get a new version of the sitemap plugin, but for now, let's just overwrite the default explicitly to fix the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment