New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #6137 for v3.4.x: Default `baseurl` to `nil` instead of empty string #6146

Merged
merged 1 commit into from Jun 18, 2017

Conversation

Projects
None yet
2 participants
@parkr
Member

parkr commented Jun 15, 2017

This backports #6137.

Conflicting files:

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 18, 2017

Member

Tests:

Finished tests in 106.241979s, 7.0123 tests/s, 12.0291 assertions/s.
745 tests, 1278 assertions, 0 failures, 0 errors, 0 skips
204 scenarios (204 passed)
1675 steps (1675 passed)
1m59.714s
Member

parkr commented Jun 18, 2017

Tests:

Finished tests in 106.241979s, 7.0123 tests/s, 12.0291 assertions/s.
745 tests, 1278 assertions, 0 failures, 0 errors, 0 skips
204 scenarios (204 passed)
1675 steps (1675 passed)
1m59.714s

@parkr parkr merged commit 628d62b into 3.4-stable Jun 18, 2017

@parkr parkr deleted the 3.4-stable-backport-6137 branch Jun 18, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 18, 2017

Member

Lol. Actually done in d7e70c4. This script has a lot to learn!

Member

parkr commented Jun 18, 2017

Lol. Actually done in d7e70c4. This script has a lot to learn!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 18, 2017

Member

Released as v3.4.4!

Member

parkr commented Jun 18, 2017

Released as v3.4.4!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment