New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation about the "pinned" label #6147

Merged
merged 4 commits into from Jun 15, 2017

Conversation

Projects
None yet
3 participants
@oe
Member

oe commented Jun 15, 2017

i noticed that documentation about this label was missing. are there any other undocumented special labels?

@oe

This comment has been minimized.

Show comment
Hide comment
Member

oe commented Jun 15, 2017

@jekyllbot jekyllbot self-assigned this Jun 15, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jun 15, 2017

Member

@pup according to the source code securityand has-pull-request also prevent an issue from being marked as stale

https://github.com/parkr/auto-reply/blob/f1933491fbda8e521572d7695dbe2bbc623e111c/cmd/mark-and-sweep-stale-issues/mark_and_sweep_stale_issues.go#L22-L25

Member

DirtyF commented Jun 15, 2017

@pup according to the source code securityand has-pull-request also prevent an issue from being marked as stale

https://github.com/parkr/auto-reply/blob/f1933491fbda8e521572d7695dbe2bbc623e111c/cmd/mark-and-sweep-stale-issues/mark_and_sweep_stale_issues.go#L22-L25

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Jun 15, 2017

Member

@DirtyF huh! the question is, do we want to list those as viable alternatives that could be used instead of pinned? i think it might cause some confusion, especially with security

Member

oe commented Jun 15, 2017

@DirtyF huh! the question is, do we want to list those as viable alternatives that could be used instead of pinned? i think it might cause some confusion, especially with security

@pathawks pathawks assigned DirtyF and unassigned jekyllbot Jun 15, 2017

@DirtyF

DirtyF approved these changes Jun 15, 2017

FIne by me.

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Jun 15, 2017

Member

i'll add a note that has-pull-request has the same effect, but shouldn't be used singularly to achieve it

Member

oe commented Jun 15, 2017

i'll add a note that has-pull-request has the same effect, but shouldn't be used singularly to achieve it

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jun 15, 2017

Member

@pup has-pull-request is often set automatically when mentioning fixand isssue number in a PR comment, so it's not a label I use very much.

Member

DirtyF commented Jun 15, 2017

@pup has-pull-request is often set automatically when mentioning fixand isssue number in a PR comment, so it's not a label I use very much.

@DirtyF

DirtyF approved these changes Jun 15, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jun 15, 2017

Member

@jekyllbot: merge +docs

Member

DirtyF commented Jun 15, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit aeb0fd7 into master Jun 15, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jekyllbot jekyllbot deleted the add-pinned-docs branch Jun 15, 2017

jekyllbot added a commit that referenced this pull request Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment