New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added direct collection access to future collection item feature test #6151

Merged
merged 3 commits into from Oct 28, 2017

Conversation

Projects
None yet
6 participants
@BrandonDusseau
Contributor

BrandonDusseau commented Jun 18, 2017

Further tests #5953
/cc @jekyll/build

@parkr

Is there a reason you didn't create a new tests here?

@BrandonDusseau

This comment has been minimized.

Show comment
Hide comment
@BrandonDusseau

BrandonDusseau Sep 1, 2017

Contributor

@parkr It would have effectively made a duplicate of the test I modified. Since the scenario described matched the situation I was testing, I modified it. I can split it out into another test if you'd like.

Contributor

BrandonDusseau commented Sep 1, 2017

@parkr It would have effectively made a duplicate of the test I modified. Since the scenario described matched the situation I was testing, I modified it. I can split it out into another test if you'd like.

Show outdated Hide outdated features/collections.feature Outdated
@BrandonDusseau

This comment has been minimized.

Show comment
Hide comment
@BrandonDusseau

BrandonDusseau Oct 28, 2017

Contributor

Split this into a separate test as previously suggested.

Contributor

BrandonDusseau commented Oct 28, 2017

Split this into a separate test as previously suggested.

@mattr-

One small tiny change and then I think we're good to go.

Show outdated Hide outdated features/collections.feature Outdated
@mattr-

mattr- approved these changes Oct 28, 2017

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Oct 28, 2017

Member

Thanks! Appreciate you adding this test! 👍

Member

mattr- commented Oct 28, 2017

Thanks! Appreciate you adding this test! 👍

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Oct 28, 2017

Member

@jekyllbot: merge +dev

Member

mattr- commented Oct 28, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 49fa2de into jekyll:master Oct 28, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@BrandonDusseau BrandonDusseau deleted the BrandonDusseau:future-collection-liquid-test branch Oct 28, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 29, 2017

Member

@mattr- I believe this is a failing test showing a behavior that isn’t working right. I see master as currently failing cucumber now on all ruby versions. Would you mind sending a patch to fix master and retry this patch with the proper fix to make the test pass?

Member

parkr commented Oct 29, 2017

@mattr- I believe this is a failing test showing a behavior that isn’t working right. I see master as currently failing cucumber now on all ruby versions. Would you mind sending a patch to fix master and retry this patch with the proper fix to make the test pass?

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Oct 29, 2017

Member

Oh! My bad! Why did I think this was passing earlier? 😞

Yup! I'll get right on fixing it.

Member

mattr- commented Oct 29, 2017

Oh! My bad! Why did I think this was passing earlier? 😞

Yup! I'll get right on fixing it.

mattr- added a commit that referenced this pull request Oct 29, 2017

mattr- added a commit that referenced this pull request Oct 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment