New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added improved Pug plugin - removed 404 Jade plugin #6174

Merged
merged 1 commit into from Jun 25, 2017

Conversation

Projects
None yet
5 participants
@DougBeney
Contributor

DougBeney commented Jun 24, 2017

I replaced the current Pug plugin, which had major flaws, with my new plugin that fixes those flaws and more. The previous Pug plugin didn't support Pug includes, Jekyll layouts, and at times was buggy with Jekyll includes.

I also removed the Jade plugin, as it was a 404 link.

Doug Beney
Added improved Pug plugin - removed 404 Jade plugin
I replaced the current Pug plugin, which had major flaws, with my new plugin that fixes those flaws and more. The previous Pug plugin didn't support Pug includes, Jekyll layouts, and at times was buggy with Jekyll includes. 

I also removed the Jade plugin, as it was a 404 link.
@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jun 24, 2017

Member

I don't know if we should just be removing other's plugins.

/cc: @jekyll/documentation

Member

pathawks commented Jun 24, 2017

I don't know if we should just be removing other's plugins.

/cc: @jekyll/documentation

@pathawks pathawks requested a review from mdxprograms Jun 24, 2017

@DougBeney

This comment has been minimized.

Show comment
Hide comment
@DougBeney

DougBeney Jun 24, 2017

Contributor

Jade plugin was removed because the link was broken, thus not providing value to reader.
The Pug plugin was replaced because it was unmaintained and lacked many useful features.

Contributor

DougBeney commented Jun 24, 2017

Jade plugin was removed because the link was broken, thus not providing value to reader.
The Pug plugin was replaced because it was unmaintained and lacked many useful features.

@DirtyF DirtyF assigned DirtyF and unassigned parkr Jun 25, 2017

@DirtyF

DirtyF approved these changes Jun 25, 2017

Thanks for helping us maintaining the plugin list up to date 😄

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jun 25, 2017

Member

@jekyllbot: merge+docs

Member

DirtyF commented Jun 25, 2017

@jekyllbot: merge+docs

@jekyllbot jekyllbot merged commit 6aa8f74 into jekyll:master Jun 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jun 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment