New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `{% raw %}` to Liquid example on site #6179

Merged
merged 1 commit into from Jun 25, 2017

Conversation

Projects
None yet
5 participants
@adamvoss
Contributor

adamvoss commented Jun 25, 2017

Fix for #6165 (comment)

Discussion: #6165 (comment)
I can change it to escaping the braces if that is what is ultimately wanted.

/cc @jekyll/documentation

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jun 25, 2017

Member

I worry this makes it less obvious that the code is Liquid.

I understand that {{ site.collections | where: "label", "myCollection" | first }} is not the most useful code, but if I copy-paste it into my site, I will get something that works, and it should be fairly simple to bend it to whatever task I am trying to accomplish.

I think throughout the site we use {{ }} and {% %} to denote Liquid syntax.
I think (hope) we use {{ }} consistently when describing filters and {% %} when describing tags.

Member

pathawks commented Jun 25, 2017

I worry this makes it less obvious that the code is Liquid.

I understand that {{ site.collections | where: "label", "myCollection" | first }} is not the most useful code, but if I copy-paste it into my site, I will get something that works, and it should be fairly simple to bend it to whatever task I am trying to accomplish.

I think throughout the site we use {{ }} and {% %} to denote Liquid syntax.
I think (hope) we use {{ }} consistently when describing filters and {% %} when describing tags.

Show outdated Hide outdated docs/_docs/collections.md
@@ -310,7 +310,7 @@ you specified in your `_config.yml` (if present) and the following information:
when iterating through <code>site.collections</code> as you may need to
filter it out.</p>
<p>You may wish to use filters to find your collection:
<code>{{ site.collections | where: "label", "myCollection" | first }}</code></p>
<code>site.collections | where: "label", "myCollection" | first</code></p>

This comment has been minimized.

@ashmaroli

ashmaroli Jun 25, 2017

Member

nope this should be

<code>{% raw %}{{ site.collections | where: "label", "myCollection" | first }}{% endraw %}</code>

That's how it is elsewhere in our docs.
The priority is for how it renders at jekyllrb.com/docs rather than github.com

@ashmaroli

ashmaroli Jun 25, 2017

Member

nope this should be

<code>{% raw %}{{ site.collections | where: "label", "myCollection" | first }}{% endraw %}</code>

That's how it is elsewhere in our docs.
The priority is for how it renders at jekyllrb.com/docs rather than github.com

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jun 25, 2017

Member

..and the PR title needs to edited as well. We're no longer removing the braces..

Member

ashmaroli commented Jun 25, 2017

..and the PR title needs to edited as well. We're no longer removing the braces..

@pathawks pathawks changed the title from Remove braces to Jekyll does not try to process as Liquid to Add {%raw%} to Liquid example on site Jun 25, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jun 25, 2017

Member

@jekyllbot: merge +docs

Member

pathawks commented Jun 25, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 17c888d into jekyll:master Jun 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jun 25, 2017

@DirtyF DirtyF changed the title from Add {%raw%} to Liquid example on site to Add `{% raw %}` to Liquid example on site Jul 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment