New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default layouts for Pages with a `layout: none` declaration #6182

Merged
merged 3 commits into from Sep 23, 2017

Conversation

Projects
None yet
5 participants
@ashmaroli
Member

ashmaroli commented Jun 26, 2017

Continuing from #6172
Resolves confusion reported in PR #6170 where-in users thought the feature added in #5933 applied to regular Jekyll::Page objects as well.

/cc @jekyll/ecosystem

jekylltools and others added some commits Jun 23, 2017

Don't render Pages into layouts if `layout: none`
Prevent rendering Jekyll::Page objects into layout if `layout: none` is set in front matter.
@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jun 26, 2017

Member

Is there anything else we need to modify so that layout: none works consistently everywhere?

Member

pathawks commented Jun 26, 2017

Is there anything else we need to modify so that layout: none works consistently everywhere?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jun 26, 2017

Member

Is there anything else we need to modify so that layout: none works consistently everywhere?

Should I move this patch and the released public_method :no_layout? from #5933 into Jekyll::Convertible instead?

Member

ashmaroli commented Jun 26, 2017

Is there anything else we need to modify so that layout: none works consistently everywhere?

Should I move this patch and the released public_method :no_layout? from #5933 into Jekyll::Convertible instead?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 26, 2017

Member

Just modify :place_in_layout? Please! You can create a helper private method but place_in_layout? Should return false if layout:none.

Member

parkr commented Jun 26, 2017

Just modify :place_in_layout? Please! You can create a helper private method but place_in_layout? Should return false if layout:none.

@pathawks

We might want to make a note somewhere that any site that has a layout named "none" will break, because everything breaks somebody's workflow.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 9, 2017

Member

because everything breaks somebody's workflow.

This was noted by Parker in this comment and since nobody reported a break so far, the safe assumption continues..

Member

ashmaroli commented Aug 9, 2017

because everything breaks somebody's workflow.

This was noted by Parker in this comment and since nobody reported a break so far, the safe assumption continues..

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 14, 2017

Member

@parkr I feel this can be included in v3.6.0..

Member

ashmaroli commented Sep 14, 2017

@parkr I feel this can be included in v3.6.0..

@ashmaroli ashmaroli referenced this pull request Sep 20, 2017

Closed

Release Jekyll v3.6.0 #6314

3 of 3 tasks complete

@parkr parkr added this to the v3.7.0 milestone Sep 21, 2017

@parkr

parkr approved these changes Sep 21, 2017

Ah, I missed this one, sorry. Feel free to release a v3.7.0 tomorrow if you want! 😄

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 21, 2017

Member

You could also call this a bugfix and release in 3.6.1 since it could be considered a bug that there's no way to exclude these files from layouts.

Member

parkr commented Sep 21, 2017

You could also call this a bugfix and release in 3.6.1 since it could be considered a bug that there's no way to exclude these files from layouts.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 23, 2017

Member

@jekyllbot: merge +minor

Member

pathawks commented Sep 23, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit e540339 into jekyll:master Sep 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashmaroli ashmaroli deleted the ashmaroli:no-layout-pages branch Oct 29, 2017

felnne added a commit to antarctica/bas-style-kit-jekyll-theme that referenced this pull request Jul 7, 2018

Basing blank layout on Jekyll’s None layout
This prevents the layout being overwritten as `none` is treated as a real layout by Jekyll.

See jekyll/jekyll#6182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment