New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set minimum requirement for jekyll-feed #6184

Merged
merged 1 commit into from Jun 26, 2017

Conversation

Projects
None yet
4 participants
@Crunch09
Member

Crunch09 commented Jun 26, 2017

Since jekyll/jekyll#6137 baseurl can be nil. Until jekyll-feed 0.8
the baseurl has been used as argument to URI.join. When baseurl
is nil this throws an exeption:

URI.join('http://example.com', nil)
ArgumentError: bad argument (expected URI object or URI string)

The usage of baseurl within jekyll-feed has been removed in
jekyll/jekyll-feed@bf728c3

/cc @jekyll/ecosystem

set minimum requirement for jekyll-feed
Since jekyll/jekyll#6137 `baseurl` can be `nil`. Until jekyll-feed 0.8
the `baseurl` has been used as argument to `URI.join`. When `baseurl`
is `nil` this throws an exeption:

> URI.join('http://example.com', nil)
> ArgumentError: bad argument (expected URI object or URI string)

The usage of `baseurl` within jekyll-feed has been removed in
jekyll/jekyll-feed@bf728c3
@pathawks

This comment has been minimized.

Show comment
Hide comment
Member

pathawks commented Jun 26, 2017

There are probably children out there holding down spacebar to stay warm in the winter! YOUR UPDATE MURDERS CHILDREN.

@pathawks

Thanks for tracking this down. It seems like there isn't anything we can do to retroactively help, aside from advising users to update jekyll-feed

@parkr

parkr approved these changes Jun 26, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jun 26, 2017

Member

@jekyllbot: merge +dev

Member

pathawks commented Jun 26, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit a0cf395 into jekyll:master Jun 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pathawks

This comment has been minimized.

Show comment
Hide comment
Member

pathawks commented Jun 26, 2017

Thanks @Crunch09!

jekyllbot added a commit that referenced this pull request Jun 26, 2017

@Crunch09 Crunch09 deleted the Crunch09:bump-jekyll-feed branch Jun 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment