New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redcarpet support to version 2 - take two #619

Merged
merged 3 commits into from Dec 15, 2012

Conversation

Projects
None yet
@tombell
Contributor

tombell commented Aug 13, 2012

Update redcarpet support to v2.

  • Fence code blocks enabled by default
@sindresorhus

This comment has been minimized.

sindresorhus commented Sep 11, 2012

Duplicate of #450

@tombell

This comment has been minimized.

Contributor

tombell commented Sep 11, 2012

#450 seems to leave out some functionality that I implemented in my branch which I discussed with @mojombo about such as the fenced code blocks.

@sindresorhus

This comment has been minimized.

sindresorhus commented Sep 11, 2012

@tombell Ok, I didn't know.

I've been waiting for fenced code blocks support in Jekyll for a year now. Would really like to get this landed.

@mrnugget

This comment has been minimized.

mrnugget commented Sep 12, 2012

+1

@hanjianwei

This comment has been minimized.

hanjianwei commented Sep 24, 2012

+1

But Jekyll crashes with this update.

[1]    80604 trace trap  jekyll --server --auto

I found a similar bug report with pygments.

@tombell

This comment has been minimized.

Contributor

tombell commented Sep 24, 2012

Passes all tests in the test suite. Where did it crash, and doing what?

@hanjianwei

This comment has been minimized.

hanjianwei commented Sep 24, 2012

Maybe the bug comes from pygments.rb. I have created a sample project.

It runs normally if I only use jekyll command to generate the site. But if I use jekyll --server --auto it complains:

Auto-regenerating enabled: source -> _site
[2012-09-24 21:08:42] regeneration: 3 files changed
[2012-09-24 21:08:43] INFO WEBrick 1.3.1
[2012-09-24 21:08:43] INFO ruby 1.9.3 (2012-04-20) [x86_64-darwin12.0.0]
[2012-09-24 21:08:43] INFO WEBrick::HTTPServer#start: pid=90705 port=4000
[1] 90705 trace trap jekyll --server --auto

If I remove all source code from the file it works very well. So I think it's a pygments.rb problem.

I use Mac OSX 10.8.2 + Ruby 1.9.3p194.

@tombell

This comment has been minimized.

Contributor

tombell commented Sep 24, 2012

Can you show me what you're trying to render, because as I said, the tests pass when I wrote it.

@tombell

This comment has been minimized.

Contributor

tombell commented Sep 24, 2012

Looks like it is a pygments.rb problem, think we'll have to see if that is updated. It's not been touched in 3 months, so we'll see.

@hanjianwei

This comment has been minimized.

hanjianwei commented Oct 7, 2012

@tombell

Looks like the bug has been fixed in the latest pygments.rb.

Hope this pull request can be merged.

@apazzolini

This comment has been minimized.

apazzolini commented Oct 11, 2012

+1

@sol

This comment has been minimized.

sol commented Oct 18, 2012

@tombell Can you cherry-pick 6c9cf30 and add it to your pull request? That way if you have

~~~ {ruby example-1}
puts "foo"
~~~

it will still work (pygments will fail with an exception otherwise).

BTW: The GitHub README renderer behaves like that.

tombell added some commits Nov 13, 2012

Only pass first class to Pygments
This prevents an exception if something like the following is used:

~~~ {foo bar}
some code
~~~
@tombell

This comment has been minimized.

Contributor

tombell commented Nov 13, 2012

This should be ready to 🤘 if anyone wants to test it with their jekyll site.

@pajtai

This comment has been minimized.

pajtai commented Nov 18, 2012

Wow, exactly what I was looking for. The last step for storing my site on github was making the syntax highlighting work on the site and on github.

Just tried it out and it works nicely with the backticks. Readable both on the ouputed html and on github: example - also, nice that the liquid highlight keeps working.

I'm not too familiar with ruby - so not sure if there's a better way to try it out, here's what I did:

git clone https://github.com/tombell/jekyll.git
cd jekyll
git checkout redcarpet-update
gem build jekyll.gemspec
gem install jekyll-0.11.2.gem
# now the bin is ready to use
sudo ln -s ~/git/jekyll/bin/jekyll /usr/local/bin/jekyll

@mojombo - +10 for this PR

@tombell - awesome!

@mattr- mattr- referenced this pull request Nov 25, 2012

Closed

Update pygments.rb to 0.3.2 #667

@envygeeks

This comment has been minimized.

Contributor

envygeeks commented Nov 28, 2012

Just a small note to anybody coming here and then listening to the duplicate comment thus ending up using #450. 450 will break your specs even though it works, so it might be better to stick with this one if this author intends to make sure specs pass.

@mojombo mojombo merged commit 38ac553 into jekyll:master Dec 15, 2012

This was referenced Dec 15, 2012

@pajtai

This comment has been minimized.

pajtai commented Dec 16, 2012

@mojombo yeah!

@dylanvee

This comment has been minimized.

dylanvee commented Jan 10, 2013

@mojombo What do you think about cherry-picking chitsaou@43ee477 from #450? SmartyPants support in Redcarpet would be nice to have. cc @chitsaou

@tombell

This comment has been minimized.

Contributor

tombell commented Jan 10, 2013

This has SmartyPants support if you add the smart extension in your config.

@dylanvee

This comment has been minimized.

dylanvee commented Jan 10, 2013

Ah, correct, it's right here. My apologies.

@jwebcat

This comment has been minimized.

jwebcat commented Mar 6, 2013

Do you have extensions: [fenced_code_blocks] underneath redcarpet in your
_config.yml?
On Mar 6, 2013 8:58 AM, "Zachary Kain" notifications@github.com wrote:

Is there any way to prevent the div with a class of highlight from being
generated? I don't want it :(


Reply to this email directly or view it on GitHubhttps://github.com//pull/619#issuecomment-14512091
.

@zakkain

This comment has been minimized.

zakkain commented Mar 6, 2013

Oh, I'll try that out! I didn't think I needed any extensions/options with
GitHub's own redcarpet thang.

Thanks

On Wed, Mar 6, 2013 at 1:44 PM, Jupiter St John notifications@github.comwrote:

Do you have extensions: [fenced_code_blocks] underneath redcarpet in your
_config.yml?
On Mar 6, 2013 8:58 AM, "Zachary Kain" notifications@github.com wrote:

Is there any way to prevent the div with a class of highlight from being
generated? I don't want it :(


Reply to this email directly or view it on GitHub<
https://github.com/mojombo/jekyll/pull/619#issuecomment-14512091>
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/619#issuecomment-14518014
.

– Zachary Kain

Designer, Creative Technologist
416-712-8895
zakkain@gmail.com
→ view my resume/profile http://zerply.com/zakkain/public

@nhanb nhanb referenced this pull request Apr 9, 2014

Open

Make guide for contributors #9

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.