New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs site page margin #6214

Merged
merged 1 commit into from Jul 9, 2017

Conversation

Projects
None yet
4 participants
@cobyism
Member

cobyism commented Jul 9, 2017

Having not looked at this site in a while, I noticed it looks like the page body has lost its margin reset. Note the space around the gold line at the top of the page in the screenshots below:

2017-07-09 at 16 34

2017-07-09 at 16 44

This PR resets the margin of the body element to zero, and also adds a little bit of horizontal padding for the mobile version of the site-nav, which otherwise wouldn’t have much space—especially when the leftmost item is the currently selected menu item:

2017-07-09 at 16 45

2017-07-09 at 16 45

/cc @parkr @mattr-

@oe

oe approved these changes Jul 9, 2017

@parkr

parkr approved these changes Jul 9, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 9, 2017

Member

Thank you so much, @cobyism! Your design endures to this day — thank you for building it!

@jekyllbot: merge +site

Member

parkr commented Jul 9, 2017

Thank you so much, @cobyism! Your design endures to this day — thank you for building it!

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 355436f into jekyll:master Jul 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jul 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment